Dedicated data members for Run-3 CSC trigger primitives #33727

dildick · 2021-05-13T17:16:46Z

PR description:

In previous PRs (#29456, #29205, #32880) I defined the Run-3 CSC TP formats based on a detector note DN-20-016. In the CLCT and LCT I extended the definition of existing data members with bit masks and bit shifts. It was pointed out to me that although this method is economical, it does not prevent data formats from being misinterpreted, should the bit masks or shifts change in the future. CMSSW would not record changes in bit masks and shifts as changes in the data formats, as opposed to changes in data members.

Bottom line: 1/4-strip bit, 1/8-strip bit, Run-3 pattern and slope now have corresponding data members in CLCT and LCT. In-time bits and out-of-time bits are separated in the CSCShowerDigi.

PR validation:

Tested with WF 11634.0. There should be no changes in any workflow.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2021-05-13T17:23:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33727/22660

This PR adds an extra 36KB to repository

cmsbuild · 2021-05-13T17:24:06Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
DataFormats/L1CSCTrackFinder
L1Trigger/CSCTriggerPrimitives
L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @rovere, @Martin-Grunewald, @dinyar, @thomreis, @ptcox this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

civanch · 2021-05-14T09:04:10Z

please test

cmsbuild · 2021-05-14T09:28:07Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24836c/15088/summary.html
COMMIT: cd66349
CMSSW: CMSSW_12_0_X_2021-05-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33727/15088/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Copying tmp/slc7_amd64_gcc900/src/L1Trigger/L1TMuonEndCap/src/L1TriggerL1TMuonEndCap/libL1TriggerL1TMuonEndCap.so to productstore area:
Leaving library rule at L1Trigger/L1TMuonEndCap
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-13-2300/src/L1Trigger/L1TMuonEndCap/test/unittests/TestDebugTools.cpp
>> Building binary TestDebugTools
/cvmfs/cms-ib.cern.ch/nweek-02680/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-2300/lib/slc7_amd64_gcc900/libL1TriggerL1TMuon.so: undefined reference to `CSCCorrelatedLCTDigi::getPattern() const'
collect2: error: ld returned 1 exit status
>> Deleted: tmp/slc7_amd64_gcc900/src/L1Trigger/L1TMuonEndCap/test/TestDebugTools/TestDebugTools
gmake: *** [tmp/slc7_amd64_gcc900/src/L1Trigger/L1TMuonEndCap/test/TestDebugTools/TestDebugTools] Error 1
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-13-2300/src/L1Trigger/L1TMuonEndCap/test/unittests/TestPhiMemoryImage.cpp
>> Building binary TestPhiMemoryImage
/cvmfs/cms-ib.cern.ch/nweek-02680/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-2300/lib/slc7_amd64_gcc900/libL1TriggerL1TMuon.so: undefined reference to `CSCCorrelatedLCTDigi::getPattern() const'

dildick · 2021-05-14T10:19:57Z

@jiafulow Do you know why compilation of the test module is not working? CSCCorrelatedLCTDigi::getPattern() const is defined and returns pattern.

  /// return the Run-2 pattern ID
  uint16_t getPattern() const { return pattern; }

dildick · 2021-05-14T17:26:17Z

With the addition of <use name="DataFormats/CSCDigi"/> the XML environment for the unit tests, they seem to compile fine for me. @civanch want to give it another try?

cmsbuild · 2021-05-14T17:33:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33727/22680

This PR adds an extra 36KB to repository

cmsbuild · 2021-05-14T17:33:32Z

Pull request #33727 was updated. @cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please check and sign again.

civanch · 2021-05-16T09:25:45Z

please test

cmsbuild · 2021-05-20T21:31:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33727/22785

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/CSCDigi/interface/CSCCLCTDigi.h modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File DataFormats/CSCDigi/interface/CSCCorrelatedLCTDigi.h modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File DataFormats/CSCDigi/interface/CSCShowerDigi.h modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File DataFormats/CSCDigi/src/CSCCLCTDigi.cc modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File DataFormats/CSCDigi/src/CSCCorrelatedLCTDigi.cc modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File DataFormats/CSCDigi/src/CSCShowerDigi.cc modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File DataFormats/CSCDigi/src/classes_def.xml modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File DataFormats/L1CSCTrackFinder/src/classes_def.xml modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc modified in PR(s): [Do not merge] Test PR for #33781 #33783
- File L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc modified in PR(s): [Do not merge] Test PR for #33781 #33783

cmsbuild · 2021-05-20T21:31:30Z

Pull request #33727 was updated. @cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please check and sign again.

dildick · 2021-05-21T15:34:18Z

scram b runtests
****WARNING: Invalid tool py2-sympy. Please fix professor2 file.
>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Entering Package EventFilter/CSCRawToDigi
>> Creating project symlinks
>> Entering Package DataFormats/L1CSCTrackFinder
>> Entering Package DataFormats/CSCDigi
>> Leaving Package EventFilter/CSCRawToDigi
>> Package EventFilter/CSCRawToDigi built
Creating test log file logs/slc7_amd64_gcc900/testing.log
Package EventFilter/CSCRawToDigi: Running test cscRawToDigiTest
 
===== Test "cscRawToDigiTest" ====

---> test cscRawToDigiTest succeeded
 
^^^^ End Test cscRawToDigiTest ^^^^
>> Tests for package EventFilter/CSCRawToDigi ran.

dildick · 2021-05-24T13:04:25Z

@civanch Can you restart the tests, please?

civanch · 2021-05-24T14:46:20Z

please test

cmsbuild · 2021-05-24T17:54:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24836c/15274/summary.html
COMMIT: 60d05fb
CMSSW: CMSSW_12_0_X_2021-05-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33727/15274/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

dildick · 2021-05-25T17:11:48Z

Only 1 failed comparison, from pixel in WF 8.0.

@civanch @cecilecaillol Can you sign, please?

civanch · 2021-05-26T20:26:19Z

+1

dildick · 2021-05-27T15:48:08Z

@cecilecaillol Can this be merged as well?

cecilecaillol · 2021-05-27T16:06:16Z

+l1

cmsbuild · 2021-05-27T16:06:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

dildick · 2021-05-28T03:00:20Z

@qliphy Can this PR be merged? Thanks.

qliphy · 2021-05-28T03:02:26Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone May 13, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures simulation-pending tests-pending labels May 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 13, 2021

cmsbuild added tests-started and removed tests-pending labels May 14, 2021

cmsbuild added tests-rejected and removed tests-started labels May 14, 2021

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels May 14, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 14, 2021

cmsbuild added tests-started and removed tests-pending labels May 16, 2021

cmsbuild added the code-checks-rejected label May 20, 2021

cmsbuild added code-checks-approved and removed code-checks-rejected labels May 20, 2021

cmsbuild added tests-started and removed tests-pending labels May 24, 2021

cmsbuild added tests-approved and removed tests-started labels May 24, 2021

cmsbuild added simulation-approved and removed simulation-pending labels May 26, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 27, 2021

cmsbuild added orp-approved and removed orp-pending labels May 28, 2021

cmsbuild merged commit 025e9cc into cms-sw:master May 28, 2021

dildick deleted the from-CMSSW_12_0_X_2021-05-12-1100-data-members-run3-variables branch May 28, 2021 03:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dedicated data members for Run-3 CSC trigger primitives #33727

Dedicated data members for Run-3 CSC trigger primitives #33727

dildick commented May 13, 2021 •

edited

Loading

cmsbuild commented May 13, 2021

cmsbuild commented May 13, 2021

civanch commented May 14, 2021

cmsbuild commented May 14, 2021

dildick commented May 14, 2021 •

edited

Loading

dildick commented May 14, 2021

cmsbuild commented May 14, 2021

cmsbuild commented May 14, 2021

civanch commented May 16, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

dildick commented May 21, 2021

dildick commented May 24, 2021

civanch commented May 24, 2021

cmsbuild commented May 24, 2021

dildick commented May 25, 2021

civanch commented May 26, 2021

dildick commented May 27, 2021

cecilecaillol commented May 27, 2021

cmsbuild commented May 27, 2021

dildick commented May 28, 2021

qliphy commented May 28, 2021

Dedicated data members for Run-3 CSC trigger primitives #33727

Dedicated data members for Run-3 CSC trigger primitives #33727

Conversation

dildick commented May 13, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 13, 2021

cmsbuild commented May 13, 2021

civanch commented May 14, 2021

cmsbuild commented May 14, 2021

Build

dildick commented May 14, 2021 • edited Loading

dildick commented May 14, 2021

cmsbuild commented May 14, 2021

cmsbuild commented May 14, 2021

civanch commented May 16, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

dildick commented May 21, 2021

dildick commented May 24, 2021

civanch commented May 24, 2021

cmsbuild commented May 24, 2021

Comparison Summary

dildick commented May 25, 2021

civanch commented May 26, 2021

dildick commented May 27, 2021

cecilecaillol commented May 27, 2021

cmsbuild commented May 27, 2021

dildick commented May 28, 2021

qliphy commented May 28, 2021

dildick commented May 13, 2021 •

edited

Loading

dildick commented May 14, 2021 •

edited

Loading