Run-3 CLCT and LCT data formats (CCLUT-3)

[dildick]

PR description:

This pull requests implements the CLCT and LCT data formats for Run-3 data taking. The Run-3 CSC local trigger will be notably different than then Run-1/2 trigger. CSC stubs will have a higher resolution in position (x2 to x4) and bending (x3). This is achieved by implementing a 12-bit comparator code data word (CCLUT algorithm). It is set by default to -1 for Run-1/2 CLCTs. For Run-3 it takes a value between 0 and 2^12 - 1. The halfstrip number of CLCT and LCT is given 2 extra bits, one for the 1/4 strip value and one for the 1/8 strip value. In addition, I added a new ComparatorContainer object to keep track of which comparators were used to build a CLCT.

This PR is a follow-up of #28846. But the code is written such that the original functions retain their original meaning for the default arguments. The actual CCLUT algorithm will be implemented in a separate PR.

More information can be found here:
https://indico.cern.ch/event/881406/contributions/3713334/attachments/1973349/3283422/CSC_NewPatterns_SD_20200121.pdf

PR validation:

Tested with WF 22034.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@barvic @tahuang1991 @ptcox

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29205/14194

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5181/console Started: 2020/03/15 13:48

[cmsbuild]

+1
Tested at: d905340
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32747d/5181/summary.html
CMSSW: CMSSW_11_1_X_2020-03-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32747d/5181/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680593
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680273
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

please test workflow 23234.1001, 23434.1001

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 23434.1001,23234.1001
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5193/console Started: 2020/03/16 10:14

[cmsbuild]

+1
Tested at: d905340
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32747d/5193/summary.html
CMSSW: CMSSW_11_1_X_2020-03-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32747d/5193/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-32747d/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-32747d/23434.1001_TTbar_14TeV+RecoFullGlobalPU_TestOldDigi_2026D49PU+HARVESTFullGlobalPU_2026D49PU

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680593
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680273
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[silviodonato]

+1