Cast legacy CLCT trigger patterns in Run-3 pattern format (CCLUT-2)

[dildick]

PR description:

This PR casts the legacy CSC trigger patterns in the Run-3 CSC pattern format. The old patterns are defined as 1D arrays with length 42. This will change to 2D vector with width 11 and depth 6. More details can be found here [1], page 3-8. The Run-3 patterns have previously been defined in #28600. Because this PR merely replace the 1D array with a 2D vector, there should be no changes in the output.

I also remove very outdated code (pre-2007) in the CSCCommonTrigger and CSCTrackFinder packages (NUM_CLCT_PATTERNS_PRE_TMB07)

[1]
https://indico.cern.ch/event/882849/contributions/3722003/attachments/1977056/3296463/CSCTriggerPlans2020_SvenDildick_L1TDPG.pdf

PR validation:

Tested with wf 22034.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI @tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28846/13594

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28846/13594/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28846/13594/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28846/13595

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCCommonTrigger
L1Trigger/CSCTrackFinder
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @valuev this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28846/13596

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #28846 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

[cmsbuild]

+1
Tested at: 2152452
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e7026/5140/summary.html
CMSSW: CMSSW_11_1_X_2020-03-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e7026/5140/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680577
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680257
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[dildick]

Plots looks good. The differences between emulator and firmware are in >90% coming from ME1/1. That is something we plan to improve during LS2.

[dildick]

@rekovic Could you sign, please?

[silviodonato]

Kind reminder to @benkrikler @rekovic

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[dildick]

Thank you Vladimir!