-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define CLCT patterns for Run-3 (CCLUT-1) #28600
Define CLCT patterns for Run-3 (CCLUT-1) #28600
Conversation
The code-checks are being triggered in jenkins. |
1 similar comment
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28600/13113
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
During Run-3 the CSC DPG group is planning to run the CSC trigger with new CLCT patterns based on a 12-bit comparator code. They are noticeably different than the ones defined in 2007. An introduction to the new CLCT patterns can be found here [1]. Accordingly, we will have to change the data formats for both CLCT and LCT for Run-3. A proposal for the CLCT is being developed. A proposal for the LCT format can be found here [2], p13.
The plan to integrate the new patterns in the CSCCLCTProcessor is as follows:
Beyond the above mentioned changes in the CSCCLCTProcessor, there will be changes to the LCT data format in simulation, the (O)TMBs (with and without GEM), the packer/unpacker, the DQM/validation,...
[1]
https://indico.cern.ch/event/778315/contributions/3238278/subcontributions/268636/attachments/1770627/2876988/181213-CCStatus_WNASH.pdf
[2]
https://indico.cern.ch/event/869092/contributions/3664061/subcontributions/294640/attachments/1956917/3252387/Tao_LCTformat_20191204.pdf
PR validation:
Compiled the code
if this PR is a backport please specify the original PR:
N/A
@tahuang1991 @ptcox