Alca packages: cleanup use of GCC11Compatibility.h #29121

gartung · 2020-03-05T21:13:02Z

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-03-05T21:13:22Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-05T21:21:47Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29121/14027

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29121/14027/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29121/14027/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

makortel · 2020-03-05T21:56:10Z

part of #28747

cmsbuild · 2020-03-05T22:13:03Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-05T22:17:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29121/14039

This PR adds an extra 16KB to repository

cmsbuild · 2020-03-05T22:17:57Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

CalibFormats/SiStripObjects
CondFormats/SiPixelObjects

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@tocheng, @VinInn, @dkotlins, @mmusich, @threus, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

gartung · 2020-03-05T22:27:03Z

please test

cmsbuild · 2020-03-05T22:27:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5027/console Started: 2020/03/05 23:29

cmsbuild · 2020-03-06T00:09:12Z

+1
Tested at: 3748ce2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd5f0/5027/summary.html
CMSSW: CMSSW_11_1_X_2020-03-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-03-06T00:09:14Z

Comparison job queued.

cmsbuild · 2020-03-17T09:24:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5213/console Started: 2020/03/17 10:45

cmsbuild · 2020-03-17T11:25:19Z

+1
Tested at: 894ec1e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd5f0/5213/summary.html
CMSSW: CMSSW_11_1_X_2020-03-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-03-17T11:25:22Z

Comparison job queued.

cmsbuild · 2020-03-17T12:52:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd5f0/5213/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2680593
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2680273
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2020-03-17T19:24:59Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #29124
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5230/console Started: 2020/03/17 20:35

silviodonato · 2020-03-17T20:46:24Z

merge

cmsbuild · 2020-03-17T23:26:04Z

+1
Tested at: 894ec1e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdb816/5230/summary.html
CMSSW: CMSSW_11_1_X_2020-03-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-03-17T23:26:08Z

Comparison job queued.

cmsbuild · 2020-03-18T00:57:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdb816/5230/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2680593
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2680272
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild added this to the CMSSW_11_1_X milestone Mar 5, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Mar 5, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 5, 2020

makortel mentioned this pull request Mar 5, 2020

FWCore packages: cleanup use of GCC11Compatibility.h #29124

Merged

gartung force-pushed the gartung-gcc11compatibility-cleanup-alca branch from 2e080bf to 3748ce2 Compare March 5, 2020 22:12

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 5, 2020

cmsbuild added tests-started and removed tests-pending labels Mar 5, 2020

cmsbuild added tests-approved and removed tests-started labels Mar 6, 2020

cmsbuild added comparison-pending tests-pending labels Mar 17, 2020

cmsbuild added tests-started and removed tests-pending labels Mar 17, 2020

cmsbuild added tests-approved and removed tests-started labels Mar 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Mar 17, 2020

cmsbuild added requires-external tests-started and removed tests-approved labels Mar 17, 2020

cmsbuild added orp-approved and removed orp-pending labels Mar 17, 2020

cmsbuild merged commit 32ef34b into cms-sw:master Mar 17, 2020

gartung deleted the gartung-gcc11compatibility-cleanup-alca branch March 17, 2020 20:57

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Mar 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Mar 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alca packages: cleanup use of GCC11Compatibility.h #29121

Alca packages: cleanup use of GCC11Compatibility.h #29121

gartung commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

makortel commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

gartung commented Mar 5, 2020

cmsbuild commented Mar 5, 2020 •

edited

Loading

cmsbuild commented Mar 6, 2020

cmsbuild commented Mar 6, 2020

cmsbuild commented Mar 17, 2020 •

edited

Loading

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020 •

edited

Loading

silviodonato commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 18, 2020

Alca packages: cleanup use of GCC11Compatibility.h #29121

Alca packages: cleanup use of GCC11Compatibility.h #29121

Conversation

gartung commented Mar 5, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

makortel commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

cmsbuild commented Mar 5, 2020

gartung commented Mar 5, 2020

cmsbuild commented Mar 5, 2020 • edited Loading

cmsbuild commented Mar 6, 2020

cmsbuild commented Mar 6, 2020

cmsbuild commented Mar 17, 2020 • edited Loading

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020 • edited Loading

silviodonato commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 17, 2020

cmsbuild commented Mar 18, 2020

cmsbuild commented Mar 5, 2020 •

edited

Loading

cmsbuild commented Mar 17, 2020 •

edited

Loading

cmsbuild commented Mar 17, 2020 •

edited

Loading