Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WireDigi container in ALCT (ACLUT-1) #30102

Merged
merged 1 commit into from
Jun 6, 2020
Merged

WireDigi container in ALCT (ACLUT-1) #30102

merged 1 commit into from
Jun 6, 2020

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Jun 4, 2020

PR description:

This PR introduces a simple 2D container in the ALCT object to keep track of which anode wire digi hits were used in the construction. Similar as what is done for CLCTs here #29205. In a separate PR I'll update the emulator so that the wire digis are stored.

PR validation:

Tested with WF 27434.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30102/15850

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Jun 5, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6837/console Started: 2020/06/05 09:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

+1
Tested at: 593f253
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b03c/6837/summary.html
CMSSW: CMSSW_11_2_X_2020-06-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b03c/6837/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783960
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783880
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@civanch
Copy link
Contributor

civanch commented Jun 6, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d032aea into cms-sw:master Jun 6, 2020
@dildick dildick deleted the from-CMSSW_11_2_X_2020-06-03-1100-ALCT-wire-container branch June 7, 2020 02:55
@dildick dildick changed the title WireDigi container in ALCT WireDigi container in ALCT (ACLUT-1) Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants