Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up BuildFiles under DataFormats/ #29663

Merged
merged 1 commit into from
May 6, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29663/15065

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6032/console Started: 2020/05/05 15:41

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DataFormats/Alignment
DataFormats/BTauReco
DataFormats/BeamSpot
DataFormats/CLHEP
DataFormats/CSCDigi
DataFormats/CSCRecHit
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
DataFormats/CTPPSReco
DataFormats/CaloRecHit
DataFormats/CaloTowers
DataFormats/Candidate
DataFormats/CastorReco
DataFormats/Common
DataFormats/DTDigi
DataFormats/DTRecHit
DataFormats/DetId
DataFormats/EcalDetId
DataFormats/EcalDigi
DataFormats/EcalRawData
DataFormats/EcalRecHit
DataFormats/EgammaCandidates
DataFormats/EgammaReco
DataFormats/EgammaTrackReco
DataFormats/FEDRawData
DataFormats/FP420Cluster
DataFormats/FP420Digi
DataFormats/FTLDigi
DataFormats/FTLRecHit
DataFormats/FWLite
DataFormats/ForwardDetId
DataFormats/GEMDigi
DataFormats/GEMRecHit
DataFormats/GeometryCommonDetAlgo
DataFormats/GeometrySurface
DataFormats/GeometryVector
DataFormats/GsfTrackReco
DataFormats/HGCDigi
DataFormats/HGCRecHit
DataFormats/HGCalReco
DataFormats/HLTReco
DataFormats/HcalCalibObjects
DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/HcalIsolatedTrack
DataFormats/HcalRecHit
DataFormats/HeavyIonEvent
DataFormats/HepMCCandidate
DataFormats/Histograms
DataFormats/JetReco
DataFormats/L1CSCTrackFinder
DataFormats/L1CaloTrigger
DataFormats/L1DTTrackFinder
DataFormats/L1GlobalCaloTrigger
DataFormats/L1GlobalMuonTrigger
DataFormats/L1GlobalTrigger
DataFormats/L1TCalorimeter
DataFormats/L1TCalorimeterPhase2
DataFormats/L1TCorrelator
DataFormats/L1TGlobal
DataFormats/L1THGCal
DataFormats/L1TMuon
DataFormats/L1TParticleFlow
DataFormats/L1TrackTrigger
DataFormats/L1Trigger
DataFormats/LTCDigi
DataFormats/Luminosity
DataFormats/METReco
DataFormats/Math
DataFormats/MuonDetId
DataFormats/MuonReco
DataFormats/MuonSeed
DataFormats/NanoAOD
DataFormats/OnlineMetaData
DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/PatCandidates
DataFormats/Phase2TrackerCluster
DataFormats/Phase2TrackerDigi
DataFormats/Provenance
DataFormats/RPCDigi
DataFormats/RPCRecHit
DataFormats/RecoCandidate
DataFormats/Scalers
DataFormats/Scouting
DataFormats/SiPixelCluster
DataFormats/SiPixelDetId
DataFormats/SiPixelDigi
DataFormats/SiPixelRawData
DataFormats/SiStripCluster
DataFormats/SiStripCommon
DataFormats/SiStripDetId
DataFormats/SiStripDigi
DataFormats/StdDictionaries
DataFormats/Streamer
DataFormats/TCDS
DataFormats/TauReco
DataFormats/TestObjects
DataFormats/TrackCandidate
DataFormats/TrackReco
DataFormats/TrackerCommon
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
DataFormats/TrajectorySeed
DataFormats/TrajectoryState
DataFormats/V0Candidate
DataFormats/VertexReco
DataFormats/WrappedStdDictionaries

@SiewYan, @andrius-k, @emeschi, @schneiml, @kpedro88, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @santocch, @peruzzim, @perrotta, @civanch, @makortel, @cmsbuild, @agrohsje, @fwyzard, @GurpreetSinghChahal, @smuzaffar, @Dr15Jones, @efeyazgan, @mdhildreth, @jfernan2, @tocheng, @slava77, @mommsen, @qliphy, @benkrikler, @mkirsano, @kmaeshima, @christopheralanwest, @fgolf can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @gouskos, @echabert, @yslai, @felicepantaleo, @jainshilpi, @schoef, @robervalwalsh, @emilbols, @sviret, @argiro, @jshlee, @Fedespring, @thomreis, @mandrenguyen, @ahinzmann, @lgray, @abbiendi, @peruzzim, @seemasharmafnal, @mmarionncern, @smoortga, @sethzenz, @calderona, @makortel, @threus, @jhgoh, @amagitte, @jdolen, @jbsauvan, @cericeci, @dildick, @battibass, @pieterdavid, @forthommel, @yetkinyilmaz, @apsallid, @vandreev11, @Sam-Harper, @cbernet, @rovere, @VinInn, @cseez, @ferencek, @nhanvtran, @gkasieczka, @tocheng, @deguio, @hatakeyamak, @alesaggio, @mmusich, @ptcox, @abdoulline, @fabiocos, @clelange, @kreczko, @jdamgov, @HuguesBrun, @trocino, @riga, @jan-kaspar, @varuns23, @wddgit, @JyothsnaKomaragiri, @mverzett, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @amarini, @andrzejnovak, @folguera, @pfs this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: e0aa093
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2132cb/6032/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2132cb/6032/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2132cb/6032/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2132cb/6032/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@makortel
Copy link
Contributor

makortel commented May 6, 2020

+core

@qliphy
Copy link
Contributor

qliphy commented May 6, 2020

+1

@jfernan2
Copy link
Contributor

jfernan2 commented May 6, 2020

+1
Changes due to #29628

@civanch
Copy link
Contributor

civanch commented May 6, 2020

+1

@peruzzim
Copy link
Contributor

peruzzim commented May 6, 2020

+xpog

@perrotta
Copy link
Contributor

perrotta commented May 6, 2020

+1

  • Technical
  • Changes are only in white spaces and empty lines
  • Jenkins tests pass
  • (Trying to clean up the queue of pendig pull requests for reconstruction)
  • "DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates" due to testing this together with Added particle flow candidates to particle flow validation #29628

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f7d1151 into cms-sw:master May 6, 2020
@santocch
Copy link

santocch commented May 7, 2020

+1

@fwyzard fwyzard deleted the branch_lintBuildFile_DataFormats branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment