[HLS] Apply constexpr patch

[smuzaffar]

This should fix the DBG build issues ( see cms-sw/cmssw#44946 )

[cmsbuild]

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test with cms-sw/cmssw#44974

[smuzaffar]

please test with cms-sw/cmssw#44974 for CMSSW_14_1_DBG_X

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aca5/39383/summary.html
COMMIT: 1cb3882
CMSSW: CMSSW_14_1_X_2024-05-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9193/39383/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @abdoulline HBHE stuck ADC filter cmssw#44955
• @gkaratha fixing bugs in track triplet cmssw#44677
• @cms-sw cmssw-osenv: make sure to use scram v2 in el6 env #9191

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aca5/39383/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aca5/39383/git-merge-result

RelVals-INPUT

• 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338976
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338953
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aca5/39385/summary.html
COMMIT: 1cb3882
CMSSW: CMSSW_14_1_DBG_X_2024-05-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9193/39385/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Duchstf L1 Modify Btag Jet Types [Merged with 14_0_0_pre3] cmssw#44577
• @gkaratha fixing bugs in track triplet cmssw#44677
• @mmusich Pixel GPU client: fix siPixelPhase1RawDataErrorComparator collections post-alpaka migration cmssw#44933
• @mmusich change input siPixelClusters collection for 1040.0 wf step2 cmssw#44932
• @p2l1-gtEmulator PuppiNNTau to Phase2GT interface refactor cmssw#44737
• @iarspider [GCC13] Fix Woverloaded-virtual warning cmssw#44581
• @bsunanda Phase2-hgx355 Provision for the passive layers of HGCal in the V19 version cmssw#44907
• @stahlleiton Use singularity for gridpack generation cmssw#44900
• @DenkMybu Computation of silicon strip hit efficiency : Consecutive missing hits recovery cmssw#44858
• @Dr15Jones Added noexcept to methods called by async functions cmssw#44902
• @abhih1 Change parameters for ECAL MLDQM  cmssw#44929
• @abdoulline HBHE stuck ADC filter cmssw#44955
• @Dr15Jones Added noexcept to more methods called by async cmssw#44950
• @makortel Use standard edm::exceptionContext() in Worker::prePrefetchSelectionAsync() cmssw#44944
• @rseidita Adding per-LS MEs for Muon POG DQM cmssw#44952
• @rovere Add L1 filters early on for Muon paths cmssw#44905
• @cms-tsg-storm HLT menu development for 14_0_X (7/N) [14_1_X] cmssw#44948
• @BenjaminRS L1TP2: Bug Fix: Adding a setting of TTTrack word to allow Track Quality MVA to read variables cmssw#44897
• @jonamotta Fix L1NNCaloTau verbosity cmssw#44770
• @kbunkow OMTF emulator corresponding to the 2024 OMTF firmware cmssw#44893
• @rseidita Fixing JECs for PUPPI in offline DQM cmssw#44959

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aca5/39385/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aca5/39385/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test unitTestsGroup_1_u1 had ERRORS
---> test unitTestsGroup_4_u19 had ERRORS
---> test unitTestsGroup_6_u33 had ERRORS

Comparison Summary

Summary:

• You potentially added 250 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 14578 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3325956
• DQMHistoTests: Total failures: 46707
• DQMHistoTests: Total nulls: 80
• DQMHistoTests: Total successes: 3279149
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 766.8720000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 12834.0,... ): 83.939 KiB HLT/EGM
• DQMHistoSizes: changed ( 12834.0,... ): 35.131 KiB HLT/HLTEgammaValidation
• DQMHistoSizes: changed ( 12834.0,... ): 7.070 KiB HLT/Filters
• DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.090 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): -0.012 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 24834.0,... ): -2.160 KiB HLT/Muon
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 11 / 46 workflows

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44974