L1 Modify Btag Jet Types [Merged with 14_0_0_pre3]

[Duchstf]

Description from cms-l1t-offline#1198

PR description:

Modifications of jet types in order to package the btagging scores.

PR validation:

Everything should compiles, I tested this in conjunction with this PR in the hardware development branch: https://gitlab.cern.ch/cms-cactus/phase2/firmware/correlator-common/-/merge_requests/156#note_7488170

It was merged there, propagating the same changes to master.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44577/39734

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/L1TParticleFlow/interface/gt_datatypes.h modified in PR(s): Phase2 L1T, Correlator Layer-2 : support emulation of with TMUX18 input + GT interface tweaks #44346

[cmsbuild]

A new Pull Request was created by @Duchstf for master.

It involves the following packages:

• DataFormats/L1TParticleFlow (l1, upgrade)

@aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@rovere, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-410cca/38520/summary.html
COMMIT: 50688e3
CMSSW: CMSSW_14_1_X_2024-03-31-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44577/38520/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 140 lines from the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297469
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297449
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

I have more or less forgotten to use the dedicated upgrade workflow for testing phase 2 PRs (#43271). We should be doing that.

[aloeliger]

please test workflow 24834.78

[SohamBhattacharya]

As the P2GT output was not previously stored in the output by default, HLT was modified to run the GT emulator in it (see here), in order to make the workflows work.
Now if the workflows are modified to include the P2GT step, then indeed, the bit in the aforementioned link can be removed. I think that should resolve the issue.
But note that all workflows running the Phase2 HLT will have to be modified to add the P2GT step.

[SohamBhattacharya]

N.B. #44751 Removes the P2GT steps from withing the HLT config, as now there is a dedicated step for it.

[aloeliger]

test parameters:

• pull_requests = [14_1_X] [Phase-2] Changed Phase-2 JME and BTV HLT paths to use the L1 P2GT emulator #44751
• workflow = 24834.78
• relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-410cca/39119/summary.html
COMMIT: 50688e3
CMSSW: CMSSW_14_1_X_2024-04-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44577/39119/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 96 lines from the logs
• Reco comparison results: 146 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3326929
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3326900
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 204 log files, 166 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[aloeliger]

+l1

[srimanob]

Hi @Duchstf

Could you please elaborate more, the PR description is unclear to me. Why this was merged in 14_0_0_pre3, but need to be done in master now? I think I may mis-information. If it is mentioned in L1 branch, please copy it to the PR description. Thx.

[Duchstf]

@srimanob Hello, I think this is the usual workflow of L1 phase 2 software? To be honest I think these kinds of things should be unncessary but we have been doing this for years now? In anycase I copied the PR description.

The point is we are just adding a modification to phase 2 jet types to accommodate for b-tag jet scores to be sent to the global trigger. This is merged in L1 development cmssw branch but not propagated into master branch so this is the purpose of the PR.

Thanks,

Duc.

[srimanob]

Hi @Duchstf
Let's me re-phase my question, I don't understand "[Merged with 14_0_0_pre3]" in the PR title. From CMSSW point-of-view, the PR should be merged to master first, then backport to 14_0. So, I just wonder why it goes to 14_0 first before this PR. That is what I ask for clarification.

However, as this PR goes to master, it is fine to me.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1