Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use singularity for gridpack generation #44900

Merged
merged 1 commit into from
May 13, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR implements the use of singularity to run over the gridpacks that have been produced in different architectures.
It attempts to solve the issue raised in #44863

@bbilin @menglu21

PR validation:

Tested it by running the gridpack from relval 180.1 and 181.1 (produced in EL8) on lxplus7 (SLC7)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44900/40167

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2024

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • GeneratorInterface/LHEInterface (generators)

@mkirsano, @menglu21, @alberto-sanchez, @cmsbuild, @bbilin, @GurpreetSinghChahal, @SiewYan can you please review it and eventually sign? Thanks.
@mkirsano, @alberto-sanchez this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

test parameters:

  • workflow = 180.1,181.1

@smuzaffar
Copy link
Contributor

please test for slc7_amd64_gcc12

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-013695/39232/summary.html
COMMIT: 2e5ac42
CMSSW: CMSSW_14_1_X_2024-05-03-1100/slc7_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44900/39232/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 188 lines to the logs
  • Reco comparison results: 65062 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3540970
  • DQMHistoTests: Total failures: 229894
  • DQMHistoTests: Total nulls: 301
  • DQMHistoTests: Total successes: 3310755
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.5789999999999997 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.308 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 2.381 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 141.042 ): 0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.064 KiB SiStrip/MechanicalView
  • Checked 212 log files, 173 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 15 / 48 workflows

@bendavid
Copy link
Contributor

bendavid commented May 4, 2024

Does this work if the cmsRun job is already running inside of singularity?

@smuzaffar
Copy link
Contributor

Does this work if the cmsRun job is already running inside of singularity?

yes @bendavid , it works. Note that all CMSSW PR/IB jobs already run under singularity container

@bendavid
Copy link
Contributor

bendavid commented May 4, 2024

Interesting. This could possibly be used as an alternative/more universal solution to avoid untarring gridpacks in that case.

@stahlleiton
Copy link
Contributor Author

@cms-sw/generators-l2 : please review/sign this PR

@DickyChant
Copy link

I think this is the right way to proceed, and regarding "container inside container" we did test privately with @mseidel42 with exactly powheg lol

@bbilin
Copy link
Contributor

bbilin commented May 13, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@bbilin
Copy link
Contributor

bbilin commented May 13, 2024

Before creating backports, we should test this version of the script also with Powheg. Thanks

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6838ea8 into cms-sw:master May 13, 2024
11 checks passed
@stahlleiton stahlleiton deleted the Gridpack_Singularity branch May 14, 2024 00:38
@mmusich
Copy link
Contributor

mmusich commented May 14, 2024

@smuzaffar
Copy link
Contributor

smuzaffar commented May 14, 2024

ah right, this is because the scram project command run by runcmsgrid.sh use SCRAM V3 (as it is used by CMSSW_14_1_X ) . SCRAM V3 uses python3 and that is why it failed. I can fix this by updating cmssw-el6 to force use SCRAM V2. All slc6 based CMSSW releases use SCRAM V2.

@stahlleiton
Copy link
Contributor Author

ah right, this is because the scram project command run by runcmsgrid.sh use SCRAM V3 (as it is used by CMSSW_14_1_X ) . SCRAM V3 uses python3 and that is why it failed. I can fix this by updating cmssw-el6 to force use SCRAM V2. All slc6 based CMSSW releases use SCRAM V2.

Are the issues resolved now?

@smuzaffar
Copy link
Contributor

yes, isue is fixed. New cmssw-el6 has been deployed on cvmfs. Today's 11h00 IBs should not have this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants