-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update data used for the Pixel,ECal,HCal GPU online DQM clients for post-alpaka migration in the HLT menu #44971
update data used for the Pixel,ECal,HCal GPU online DQM clients for post-alpaka migration in the HLT menu #44971
Conversation
…migration in the HLT menu
cms-bot internal usage |
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44971/40255
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @antoniovagnerini, @syuvivida, @rvenditti, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals-INPUT
Comparison SummarySummary:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82225c/39401/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
cms-data/DQM-Integration#7 merged. |
+1 |
PR description:
This PR (joint with the corresponding
cms-data
update cms-data/DQM-Integration#7), is meant to supply to the Pixel, ECal and HCal GPU clients fresher streamer input files for the unit tests.This is needed because starting from online
GRun
menusV1.1.x
in 2024, the naming of the collections in output to theDQMGPUvsCPU
stream has been updated (see TSG ticket CMSHLT-3132).This has prompted
cmssw
PRs in order to comply with the changes:siPixelPhase1RawDataErrorComparator
collections post-alpaka migration #44934 (for Pixel)Due to that, the data used in unit tests currently running in IB and PR tests is out-of-synch with the collection names requested by the clients, see e.g. these logs.
The purpose of this PR (joint to the companion
cms-data
update cms-data/DQM-Integration#7) is to update the data used for the tests to a fresher set coming from run380649 (from Run2024D pp run OMS link), which features the new collection names.PR validation:
Unit tests:
now run fine, and without missing collection warnings.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, might be useful to backport to 14.0.X if accepted.