HBHE stuck ADC filter

[abdoulline]

PR description:

A rare issue may happen to HCAL RAW data: non-rotating capacitors (capId) of FE chips, which symptom is "stuck" (all the same, high-level) ADC counts in all 8 TS. _
Most of such cases are filtered out (per affected readout) by the unpacker,
if there is a corresponding error flag set by BE.
But it was found in Run3 data that there were very rare occurrences of the issue without the error flag set.
This filter is intended for selecting/scanning already taken data for further studies.

In parallel, (a development of) the relevant filtering at the entrance of the HCAL reconstruction is being considered.

PR validation:

NB: this is a standalone filter not included in any wf.
Tested by simple injection of manually altered Digi (to exactly mimic stuck ADC data):

%MSG-w HBHEstuckADCfilter: HBHEstuckADCfilter:stuckADCfilter 12-May-2024 07:49:34 CEST Run: 1 Event: 1
stuck ADC = 111 in (HE 22,39,4)

Output file (events_list_stuckADC.txt) contains a simple list of affected events in the from run:lumi:event

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44955/40228

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File EventFilter/HcalRawToDigi/plugins/BuildFile.xml modified in PR(s): Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910

[cmsbuild]

A new Pull Request was created by @abdoulline for master.

It involves the following packages:

• EventFilter/HcalRawToDigi (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@bsunanda, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[mandrenguyen]

type hcal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-331fa1/39355/summary.html
COMMIT: f08a5c0
CMSSW: CMSSW_14_1_X_2024-05-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44955/39355/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3335848
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3335828
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1
Just adds an additional filter. Not used in standard workflows.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1