Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update data used for the Pixel,ECal,HCal GPU clients for post-alpaka migration in the HLT menu #7

Merged
merged 1 commit into from
May 23, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 15, 2024

After the migration of the HLT menu in 2024 to use alpaka-based modules for the local reconstruction of the Pixel, Ecal at HLT (see TSG tickets CMSHLT-3109, CMSHLT-3125) the naming of the collections in output to the DQMGPUvsCPU stream has been updated (see TSG ticket CMSHLT-3132).
This has prompted cmssw PRs in order to comply with the changes:

Due to that, the data used in unit tests currently running in IB and PR tests is out-of-synch with the collection names requested by the clients, see e.g. these logs.
The purpose of this PR (joint to the companion cmssw PR cms-sw/cmssw#44971) is to update the data used for the tests to a fresher set coming from run380649 (from Run2024D pp run OMS link, which features the new collection names.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for branch main.

@nothingface0, @aandvalenzuela, @tjavaid, @cmsbuild, @smuzaffar, @syuvivida, @iarspider, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 15, 2024

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented May 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9465b4/39381/summary.html
COMMIT: 781068d
CMSSW: CMSSW_14_1_X_2024-05-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/7/39381/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9465b4/39381/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9465b4/39381/git-merge-result

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338953
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 16, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9465b4/39400/summary.html
COMMIT: 781068d
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/7/39400/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9465b4/39400/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9465b4/39400/git-merge-result

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338950
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmssw#44971, please check if they should be merged together

@tjavaid
Copy link

tjavaid commented May 23, 2024

+1

@antoniovilela
Copy link

+1

@antoniovilela
Copy link

merge

@cmsbuild cmsbuild merged commit e3c43b3 into cms-data:main May 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants