-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Pixel GPU client: fix siPixelPhase1RawDataErrorComparator
collections post-alpaka migration
#44934
[14.0.X] Pixel GPU client: fix siPixelPhase1RawDataErrorComparator
collections post-alpaka migration
#44934
Conversation
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@nothingface0, @antoniovagnerini, @syuvivida, @tjavaid, @cmsbuild, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild, please test |
@syuvivida is it possible to test this in a DQM playback and if successful deploy online urgently ? |
type trk, bug-fix |
… post-alpaka migration
6f2afd2
to
50b5085
Compare
Pull request #44934 was updated. @nothingface0, @cmsbuild, @antoniovagnerini, @tjavaid, @rvenditti, @syuvivida can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfe496/39311/summary.html Comparison SummarySummary:
|
urgent |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #44933
PR description:
Title says it all, provide right collections to be monitored by the
DQM/Integration/python/clients/pixelgpu_dqm_sourceclient-live_cfg.py
after the pixel local reconstruction at HLT migration to alpaka (cf https://its.cern.ch/jira/browse/CMSHLT-3125 and https://its.cern.ch/jira/browse/CMSHLT-3132).Noticed that in recent runs all plots are empty (see e.g. link) and confirmed by looking at the dqm-square logs e.g.:
PR validation:
None, the streamer files used for input tests need to be updated.
Validation will rely on a DQM replay.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
verbatim backport of #44933 to the 2024 data-taking release.