Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECAL DQM GPU input tag module names for alpaka [14_0_X] #44675

Merged

Conversation

kyungminparkdrums
Copy link

PR description:

This PR changes the input tag names for the ECAL DQM GPU client so that it can be compatible with the new Alpaka HLT menu that will go online in late April. See JIRA ticket CMSHLT-3139 and CMSHLT-3132 for more information.

hltEcalDigisFromGPU -> hltEcalDigis
hltEcalDigisLegacy -> hltEcalDigisSerialSync
hltEcalUncalibRecHitLegacy -> hltEcalUncalibRecHitSerialSync
hltEcalUncalibRecHitFromSoA -> hltEcalUncalibRecHit

PR validation:

Once the HLT menu 2024 V1.1 is online, this PR should be validated on the playback with a run which used the Alpaka HLT menu.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport to 14_0_X, which is used in production at the moment. This PR should be merged to the next 14_0_X release, to be used with the new HLT menu 2024 V1.1. Master PR is #44674

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

A new Pull Request was created by @kyungminparkdrums for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @syuvivida, @tjavaid, @nothingface0, @rvenditti can you please review it and eventually sign? Thanks.
@argiro, @francescobrivio, @threus, @batinkov, @ReyerBand, @rchatter, @wang0jin, @thomreis this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

cms-bot internal usage

@kyungminparkdrums kyungminparkdrums marked this pull request as ready for review April 9, 2024 14:42
@tjavaid
Copy link

tjavaid commented Apr 10, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e2c49/38721/summary.html
COMMIT: fd21090
CMSSW: CMSSW_14_0_X_2024-04-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44675/38721/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3350124
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3350102
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Apr 15, 2024

backport of #44674

@tjavaid
Copy link

tjavaid commented Apr 15, 2024

+1

  • P5 tests OK.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tjavaid
Copy link

tjavaid commented Apr 15, 2024

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @tjavaid
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@mmusich
Copy link
Contributor

mmusich commented Apr 17, 2024

@tjavaid why is this held back?

@tjavaid
Copy link

tjavaid commented Apr 17, 2024

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants