-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ECAL DQM GPU input tag module names for alpaka [14_0_X] #44675
Update ECAL DQM GPU input tag module names for alpaka [14_0_X] #44675
Conversation
A new Pull Request was created by @kyungminparkdrums for CMSSW_14_0_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @syuvivida, @tjavaid, @nothingface0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e2c49/38721/summary.html Comparison SummarySummary:
|
backport of #44674 |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
hold |
Pull request has been put on hold by @tjavaid |
@tjavaid why is this held back? |
unhold |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR changes the input tag names for the ECAL DQM GPU client so that it can be compatible with the new Alpaka HLT menu that will go online in late April. See JIRA ticket CMSHLT-3139 and CMSHLT-3132 for more information.
hltEcalDigisFromGPU
->hltEcalDigis
hltEcalDigisLegacy
->hltEcalDigisSerialSync
hltEcalUncalibRecHitLegacy
->hltEcalUncalibRecHitSerialSync
hltEcalUncalibRecHitFromSoA
->hltEcalUncalibRecHit
PR validation:
Once the HLT menu 2024 V1.1 is online, this PR should be validated on the playback with a run which used the Alpaka HLT menu.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is the backport to
14_0_X
, which is used in production at the moment. This PR should be merged to the next14_0_X
release, to be used with the new HLT menu 2024 V1.1. Master PR is #44674