Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1 filters early on for Muon paths #44905

Merged
merged 2 commits into from
May 13, 2024

Conversation

rovere
Copy link
Contributor

@rovere rovere commented May 6, 2024

PR description:

This PR reintroduces L1 filters for HLT Phase2 Muon paths based only on L1 objects. Purely technical.
The timing script has been updated to include the now mandatory L1P2GT step.

PR validation:

Ttested locally.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44905/40175

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

A new Pull Request was created by @rovere for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@SohamBhattacharya, @missirol, @Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented May 6, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a38c5c/39244/summary.html
COMMIT: 077b718
CMSSW: CMSSW_14_1_X_2024-05-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44905/39244/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332436
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332410
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10.8 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 24834.0,... ): -2.160 KiB HLT/Muon
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@mmusich
Copy link
Contributor

mmusich commented May 10, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e6c8423 into cms-sw:master May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants