Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated root to tip of branch v6-28-00-patches #9027

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Updated root to tip of branch v6-28-00-patches #9027

merged 1 commit into from
Feb 24, 2024

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

test parameters:

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/root628.

@iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56640d/37553/summary.html
COMMIT: b8cc831
CMSSW: CMSSW_14_1_X_2024-02-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9027/37553/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56640d/37553/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56640d/37553/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libAlignmentCocoaDaq.so
Suggestion: You can run 'scram build updateclassversion' to generate src/AnalysisDataFormats/TrackInfo/src/classes_def.xml.generated with updated ClassVersion
>> Checking EDM Class Transients in libCUDADataFormatsBeamSpot.so
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 
gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
>> Checking EDM Class Transients in libCUDADataFormatsCommon.so
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsEcalDigi.so

@iarspider
Copy link
Contributor Author

iarspider commented Feb 20, 2024 •
edited
Loading

please test for CMSSW_14_1_ROOT628_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56640d/37568/summary.html
COMMIT: b8cc831
CMSSW: CMSSW_14_1_ROOT628_X_2024-02-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9027/37568/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56640d/37568/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56640d/37568/git-merge-result

Comparison Summary

Summary:

@iarspider
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/root628 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#43974

@cmsbuild cmsbuild mentioned this pull request Feb 22, 2024
Merged
@iarspider
Copy link
Contributor Author

@cms-sw/orp-l2 could you please check and merge?

@iarspider iarspider merged commit 1513c21 into cms-sw:IB/CMSSW_14_1_X/root628 Feb 24, 2024
11 of 12 checks passed
@iarspider iarspider deleted the root-update-v6-28-00-patches-20240219 branch February 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending requires-external tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iarspider @cmsbuild