Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root update master 20221003 #8113

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Root update master 20221003 #8113

merged 1 commit into from
Oct 7, 2022

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider iarspider changed the base branch from IB/CMSSW_12_6_X/master to IB/CMSSW_12_6_X/rootmaster October 3, 2022 08:09
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_6_X/rootmaster.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bcab4/27922/summary.html
COMMIT: d9d0870
CMSSW: CMSSW_12_6_ROOT6_X_2022-10-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8113/27922/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bcab4/27922/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bcab4/27922/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test createDBObjecs had ERRORS
---> test TestGeneratorInterfaceEvtGenInterface_external_bplus had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7bcab4/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16716 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 175496
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3257131
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -0.170 KiB SiStrip/MechanicalView
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 5 / 48 workflows

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bcab4/27967/summary.html
COMMIT: d9d0870
CMSSW: CMSSW_12_6_ROOT6_X_2022-10-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8113/27967/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test createDBObjecs had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7bcab4/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16720 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 175499
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3257128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -0.170 KiB SiStrip/MechanicalView
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 5 / 48 workflows

@aandvalenzuela
Copy link
Contributor

aandvalenzuela commented Oct 6, 2022 •
edited
Loading

please test

  • Unit tests are green in IBs now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bcab4/28078/summary.html
COMMIT: d9d0870
CMSSW: CMSSW_12_6_ROOT6_X_2022-10-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8113/28078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7bcab4/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16684 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391103
  • DQMHistoTests: Total failures: 173951
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3217129
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -0.170 KiB SiStrip/MechanicalView
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 5 / 48 workflows

@aandvalenzuela aandvalenzuela merged commit c4c3811 into cms-sw:IB/CMSSW_12_6_X/rootmaster Oct 7, 2022
@cmsbuild cmsbuild mentioned this pull request Jun 7, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Aug 7, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Sep 28, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Oct 23, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 22, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Feb 2, 2024
Merged
@iarspider iarspider deleted the root-update-master-20221003 branch February 12, 2024 10:30
This was referenced Feb 19, 2024
Closed
Merged
@cmsbuild cmsbuild mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iarspider @cmsbuild @smuzaffar @aandvalenzuela