-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HLT customization for alpaka PF #43999
Fix HLT customization for alpaka PF #43999
Conversation
cms-bot internal usage |
type bugfix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43999/38919
|
A new Pull Request was created by @waredjeb for master. It involves the following packages:
@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@@ -249,6 +243,21 @@ def replaceItemsInSequence(process, itemsToReplace, replacingSequence): | |||
itemsList = [process.hltParticleFlowRecHitHBHE, process.hltParticleFlowClusterHBHE,process.hltParticleFlowClusterHCAL] | |||
process = replaceItemsInSequence(process, itemsList, process.HLTPFHcalClustering) | |||
|
|||
process.PFClusterHBHECPUSerial = cms.Sequence(process.hltHBHERecHitToSoA+process.hltPFRecHitSoAProducerHCALCPUSerial+process.hltPFClusterSoAProducerCPUSerial) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HLT sequences start with uppercase HLT
so rename to HLTPFClusterHBHECPUSerial
and propagate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this sequence used anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sequence is then added to DQM_HcalReconstruction_v6
Looks good to me. I suggested to @waredjeb to reuse the HCAL DQM path instead of creating a new one to keep the customisation simpler. |
dqmHcalRecoPathName = "DQM_HcalReconstruction_v6" | ||
dqmHcalPath= getattr(process, dqmHcalRecoPathName) | ||
dqmHcalRecoPathIndex = dqmHcalPath.index(process.hltHcalConsumerGPU) + 1 | ||
dqmHcalPath.insert(dqmHcalRecoPathIndex , process.PFClusterHBHECPUSerial) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, here - please update.
0418195
to
0a56692
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43999/38920
|
Pull request #43999 was updated. @Martin-Grunewald, @mmusich can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-703286/37532/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
preparing a fix addressing comment |
Ok since the fix would touch also the RECO I might open a different pull request and this one can get merged if you all agree. |
OK with me! (again, for 14_1 and 14_0). |
+1 |
|
||
# Add CPUSerial sequences to DQM_HcalReconstruction_v6 Path | ||
dqmHcalRecoPathName = "DQM_HcalReconstruction_v6" | ||
dqmHcalPath= getattr(process, dqmHcalRecoPathName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this getattr()
call is causing workflow failures in GPU IB, see #44046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess something like this
cmssw/HLTrigger/Configuration/python/customizeHLTforAlpaka.py
Lines 268 to 275 in 8f7db2f
dqmPixelRecoPathName = None | |
for pathName in process.paths_(): | |
if pathName.startswith('DQM_PixelReconstruction_v'): | |
dqmPixelRecoPathName = pathName | |
break | |
if dqmPixelRecoPathName == None: | |
return process |
is needed.
@waredjeb FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I update #44000 with the same fix?
yes, please
type pf |
This PR fixes the customization of Alpaka-PF introduced with #43971 with moving the CPU serial module to
DQM_HcalReconstruction_v6
GPU vs CPU comparison at DQMOnline will followup, currently we are only saving the needed collections
Validated running:
Backport:
#44000