Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customizeHLTforAlpakaParticleFlowClustering: insert DQM_HcalReconstruction_v only if present in the HLT menu #44048

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 21, 2024

resolves #44046

PR description:

Title says it all, along #43999 (comment)

PR validation:

runTheMatrix.py --what gpu -l 12434.402 -j 0 runs fine in CMSSW_14_1_GPU_X_2024-02-20-2300

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will need to be backported at #44000.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 21, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Feb 21, 2024

test parameters:

  • workflow_opts_gpu= -w upgrade
  • workflows_gpu = 12434.402, 12434.403, 12434.404, 12434.412

@mmusich
Copy link
Contributor Author

mmusich commented Feb 21, 2024

type pf, bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44048/38987

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 21, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c2cb0/37609/summary.html
COMMIT: 4190baf
CMSSW: CMSSW_14_1_X_2024-02-21-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44048/37609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 53 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248389
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248361
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Feb 22, 2024

urgent

  • to fix IB crashes

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 324179b into cms-sw:master Feb 23, 2024
15 checks passed
@mmusich mmusich deleted the customizeHLTforAlpakaParticleFlowClustering branch February 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GPU] Workflow failures from missing DQM_HcalReconstruction_v6
4 participants