Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #4401

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Oct 3, 2018

Related to comment: cms-sw/cmssw#22594 (comment)
Getting latest changes

@mrodozov
Copy link
Contributor Author

mrodozov commented Oct 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30870/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_3_X/rootmaster.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2018

-1

Tested at: 8bee2b9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4401/30870/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4401/30870/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2781672
  • DQMHistoTests: Total failures: 149
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2781349
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 125 log files, 14 edm output root files, 29 DQM output files

@slava77
Copy link
Contributor

slava77 commented Oct 4, 2018

---> test runtestPhysicsToolsPatAlgos had ERRORS

the baseline IB already has this problem
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc6_amd64_gcc700/CMSSW_10_3_ROOT6_X_2018-10-03-2300/unitTestLogs/PhysicsTools/PatAlgos#/

DQMHistoTests: Total failures: 149

these look like known cases with non-reproducible plots in L1

I think that this PR can be merged based on the integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants