Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #8020

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_5_X/rootmaster.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1c885/26814/summary.html
COMMIT: 95cd3ae
CMSSW: CMSSW_12_5_ROOT6_X_2022-08-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8020/26814/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_ROOT6_X_2022-08-14-2300/src/PhysicsTools/Utilities/interface/RooFitFunction.h:3,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_ROOT6_X_2022-08-14-2300/src/PhysicsTools/Utilities/test/testRooFitFunction.cpp:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/include/c++/10.3.0/bits/stl_pair.h: In instantiation of 'constexpr std::pair::type>::__type, typename std::__strip_reference_wrapper::type>::__type> std::make_pair(_T1&&, _T2&&) [with _T1 = std::shared_ptr; _T2 = RooTemplateProxy; typename std::__strip_reference_wrapper::type>::__type = RooTemplateProxy; typename std::__strip_reference_wrapper::type>::__type = std::shared_ptr]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_ROOT6_X_2022-08-14-2300/src/PhysicsTools/Utilities/interface/RooFitFunction.h:56:37:   required from 'root::RooFitFunction::RooFitFunction(const char*, const char*, const Expr&, RooAbsReal&, RooAbsReal&, funct::Parameter&, RooAbsReal&, funct::Parameter&, RooAbsReal&, funct::Parameter&) [with X = funct::X; Expr = funct::Expression]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_ROOT6_X_2022-08-14-2300/src/PhysicsTools/Utilities/test/testRooFitFunction.cpp:30:77:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/include/c++/10.3.0/bits/stl_pair.h:572:14: error: no matching function for call to 'std::pair, RooTemplateProxy >::pair(std::shared_ptr, RooTemplateProxy)'
  572 |       return __pair_type(std::forward<_T1>(__x), std::forward<_T2>(__y));
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/include/c++/10.3.0/bits/stl_pair.h:452:9: note: candidate: 'template std::pair<_T1, _T2>::pair(std::tuple<_Args1 ...>&, std::tuple<_Args2 ...>&, std::_Index_tuple<_Indexes1 ...>, std::_Index_tuple<_Indexes2 ...>) [with _Args1 = {_Args1 ...}; long unsigned int ..._Indexes1 = {_Indexes1 ...}; _Args2 = {_Args2 ...}; long unsigned int ..._Indexes2 = {_Indexes2 ...}; _T1 = std::shared_ptr; _T2 = RooTemplateProxy]'
  452 |         pair(tuple<_Args1...>&, tuple<_Args2...>&,
      |         ^~~~


@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1c885/26831/summary.html
COMMIT: 95cd3ae
CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8020/26831/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1c885/26831/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1c885/26831/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libCUDADataFormatsEcalRecHitSoA.so
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/nweek-02746/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-08-14-0000/lib/el8_amd64_gcc10/SimDataFormatsEncodedEventId_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.24/07 of ROOT.
Suggestion: You can run 'scram build updateclassversion' to generate src/AnalysisDataFormats/TrackInfo/src/classes_def.xml.generated with updated ClassVersion
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAlignmentCocoaFit.so
gmake: *** [tmp/el8_amd64_gcc10/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
>> Checking EDM Class Version for src/CUDADataFormats/HGCal/src/classes_def.xml in libCUDADataFormatsHGCal.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAlignmentLaserAlignment.so
Error in : version mismatch, /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-15-1100/lib/el8_amd64_gcc10/libCalibrationHcalCalibAlgos.so = 62407, ROOT = 62701
Traceback (most recent call last):


@smuzaffar
Copy link
Contributor

please test

@iarspider
Copy link
Contributor Author

@smuzaffar the build failed:

Error in <TUnixSystem::Load>: version mismatch, /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-15-1100/lib/el8_amd64_gcc10/libAnalysisDataFormatsTrackInfo.so = 62407, ROOT = 62701
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/week0/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-08-15-1100/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in <module>
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libAnalysisDataFormatsTrackInfo.so'

I guess we are still mixing master and rootmaster branches?

@smuzaffar
Copy link
Contributor

@smuzaffar the build failed:

Error in <TUnixSystem::Load>: version mismatch, /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-15-1100/lib/el8_amd64_gcc10/libAnalysisDataFormatsTrackInfo.so = 62407, ROOT = 62701
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/week0/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-08-15-1100/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in <module>
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libAnalysisDataFormatsTrackInfo.so'

I guess we are still mixing master and rootmaster branches?

this is from the old run, latest run is using the correct IB CMSSW_12_5_ROOT6_X_2022-08-15-2300

@smuzaffar
Copy link
Contributor

build is now successfull and bot is running relval tests now https://cmssdt.cern.ch/jenkins/job/ib-run-pr-relvals/23392/

@iarspider
Copy link
Contributor Author

build is now successfull and bot is running relval tests now https://cmssdt.cern.ch/jenkins/job/ib-run-pr-relvals/23392/

The checks still report failed build:
image

@smuzaffar
Copy link
Contributor

that is fine, cms/8020/el8_amd64_gcc10 status was for default IB ( i.e. without ROOT6).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1c885/26844/summary.html
COMMIT: 95cd3ae
CMSSW: CMSSW_12_5_ROOT6_X_2022-08-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8020/26844/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16471 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 37771
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3654682
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.6419999999999995 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.545 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11834.0 ): 2.372 KiB SiStrip/MechanicalView
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 5 / 50 workflows

@iarspider iarspider merged commit dc25468 into cms-sw:IB/CMSSW_12_5_X/rootmaster Aug 16, 2022
@iarspider iarspider deleted the root-update-master-20220815 branch August 16, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants