Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT628] Root update v6 28 00 patches #8548

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_2_X/root628.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a33c88/33154/summary.html
COMMIT: 2874962
CMSSW: CMSSW_13_2_ROOT628_X_2023-06-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8548/33154/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS
---> test TestGeneratorInterfaceLHEInterfaceFileReading had ERRORS

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196037
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals
tests look good (2 unit tests are failing in IBs and other 2 are due to grid certificate issue on build node (not related to this PR))

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/root628 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

This is only for ROOT628 IBs

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a33c88/33171/summary.html
COMMIT: 2874962
CMSSW: CMSSW_13_2_ROOT628_X_2023-06-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8548/33171/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_edmPickEvents had ERRORS
---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS
---> test test-das-selected-lumis had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 123 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8128 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 123314
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3072726
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.328 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants