-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wildcard imports from ROOT (they are forbidden now) #43974
Conversation
label root |
please test |
cms-bot internal usage |
type root |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43974/38881
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@perrotta, @rvenditti, @saumyaphor4252, @tjavaid, @nothingface0, @francescobrivio, @vlimant, @syuvivida, @hqucms, @mandrenguyen, @consuegs, @antoniovagnerini, @Martin-Grunewald, @mmusich, @jfernan2, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
+db |
+1 |
+1 |
+1 |
REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmsdist#9026, please check if they should be merged together |
@cms-sw/dqm-l2 gentle ping. |
REMINDER @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9027, please check if they should be merged together |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following the merge of this ROOT PR, replace wildcard imports from ROOT with explicit ones.
PR validation:
Bot tests