Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wildcard imports from ROOT (they are forbidden now) #43974

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Following the merge of this ROOT PR, replace wildcard imports from ROOT with explicit ones.

PR validation:

Bot tests

@iarspider
Copy link
Contributor Author

label root

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

type root

@cmsbuild cmsbuild added the root label Feb 15, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43974/38881

  • This PR adds an extra 116KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • Calibration/EcalAlCaRecoProducers (alca)
  • CondCore/PopCon (alca, db)
  • DQM/SiStripMonitorClient (dqm)
  • DQM/TrackerRemapper (dqm)
  • DQMOffline/CalibCalo (dqm)
  • DQMServices/Components (dqm)
  • DataFormats/PatCandidates (reconstruction, xpog)
  • HLTrigger/Tools (hlt)
  • PhysicsTools/PythonAnalysis (analysis)
  • RecoBTag/PerformanceDB (reconstruction)
  • RecoVertex/BeamSpotProducer (alca, reconstruction)
  • Validation/MuonGEMHits (dqm)
  • Validation/RecoTau (dqm)
  • Validation/RecoVertex (dqm)

@perrotta, @rvenditti, @saumyaphor4252, @tjavaid, @nothingface0, @francescobrivio, @vlimant, @syuvivida, @hqucms, @mandrenguyen, @consuegs, @antoniovagnerini, @Martin-Grunewald, @mmusich, @jfernan2, @tvami can you please review it and eventually sign? Thanks.
@andrzejnovak, @arossi83, @fwyzard, @thomreis, @Senphy, @emilbols, @jandrea, @jshlee, @VourMa, @tocheng, @threus, @fioriNTU, @rsreds, @idebruyn, @JyothsnaKomaragiri, @rociovilar, @rchatter, @felicepantaleo, @Martin-Grunewald, @yuanchao, @missirol, @venturia, @francescobrivio, @hatakeyamak, @watson-ij, @JanFSchulte, @AlexDeMoor, @GiacomoSguazzoni, @wang0jin, @sroychow, @demuller, @Ming-Yan, @gpetruc, @silviodonato, @PonIlya, @ReyerBand, @AnnikaStein, @mtosi, @VinInn, @rovere, @gouskos, @argiro, @mmusich, @dgulhan, @barvic this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Feb 15, 2024

+1

@francescobrivio
Copy link
Contributor

+db

@Martin-Grunewald
Copy link
Contributor

+1

@jfernan2
Copy link
Contributor

+1

@tvami
Copy link
Contributor

tvami commented Feb 20, 2024

+1

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmsdist#9026, please check if they should be merged together

@iarspider
Copy link
Contributor Author

@cms-sw/dqm-l2 gentle ping.

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9027, please check if they should be merged together

@tjavaid
Copy link

tjavaid commented Feb 23, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4437a69 into cms-sw:master Feb 23, 2024
11 checks passed
@iarspider iarspider deleted the rootmaster-fix branch February 24, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.