Pull request #244
Closed
Pull request #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wy-hh
commented
Jan 2, 2025
wy-hh
commented
…hip#36437) * Adding python code for granating data model xml .gni file * Fixed python code and remove buildable * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py Co-authored-by: Andrei Litvin <[email protected]> * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py Co-authored-by: Andrei Litvin <[email protected]> * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py Co-authored-by: Andrei Litvin <[email protected]> * Fixed mismatches and typo from suggestion commits * Fixed file configuraton to figure out the right directory, so this can be run from anywhere * Restyled by autopep8 * Restyled by isort * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
We should not be comparing strings by pointer value.
… files (project-chip#36460) * Split source between wifi platforms * Brake out wiseconnect specific code from the common abstraction * move power save function to specific interface * Remove hw state from extern C * Remove power save call form extern C * Remove unnecessary include * Restyle * Fix ifdef c++ include guards
… it supports. (project-chip#36459) It turned out to be easy to use it for some struct type and get weird behavior; we should not allow that to compile.
…5429) * changing deprecated GN flag * Restyled by shfmt * Restyled by autopep8 * removeing quotes from wildcard * more conversions * Updating dry-run golden standard files --------- Co-authored-by: Restyled.io <[email protected]>
…c changes (project-chip#36225) * da_revocation: align the revocation set generation algorithm with spec changes * Add types to few methods * address review comments * add the vid/pid checks for PAI delegated crl signer * get_paa_cert_for_crl_issuer is actually fetching the issuer cert rather than the PAA
…#36453) Two Targets are added: 1- Unit Test Mode: which executes all FuzzTests in a single binary for a few seconds 2- Continous Fuzzing Mode: we choose a specific FuzzTest, it will only stop execution once a crash occurs or user explicitly Interrupts it
…ns (project-chip#36470) - w0s and w1s are not exactly identical to w0 and w1
* Incorporate Spec updates to CameraAVStreamMgmt cluster - Use Alchemy to re-generate the xml. - Add feature tag to attributes and commands. - Remove SetViewport and ImageRotation commands. * Autogenerated files after running zap_regen_all.py.
* matter-devices.xml: Fix DEM (Simple -> Utility) This change fixes the DEM device type description in matter-devices.xml. The most relevant change is fixing the class type from Simple to Utility. This was generated using alchemy with the command: ``` alchemy/alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip-spec/ ./connectedhomeip-spec/src/device_types/DeviceEnergyManagement.adoc ``` * zap regen * Fix name to avoid unwanted changes on Zap generation.
… network ID (project-chip#36435) Signed-off-by: Martin Girardot <[email protected]>
…p#36256) * chef: Fix FanControl mode/speed interdepency behavior This PR implements the FanControl logic to ensure the interdependent behavior between Mode/Speed/Percent is coherent. This is based on what was done in the AirPurifier examples. Changes: * Removed Custom Write/Read * Updated Zap file `SpeedMax` default to 10 instead of 100 * Forward `MatterPostAttributeChangeCallback` FanControl-related changes to `ChefFanControlManager` * Implements Mode/Speed/Percent interdependency logic based on the AirPurifier example Test: * Verified that Mode, Speed and SpeedPercent change accordingly when any of those attributes change and cross a boundary. * ifdef out code for non-fancontrol examples. * Address Boris' review feedback * Update examples/chef/common/chef-fan-control-manager.cpp Co-authored-by: Andrei Litvin <[email protected]> * Andrei's review suggestions * review suggestions: clarify Auto behavior and use struct for ranges. * Fix minor bug introduced when addressing review suggestions (!= vs ==) * Update examples/chef/common/chef-fan-control-manager.cpp Co-authored-by: Andrei Litvin <[email protected]> * fix const * Apply suggestions from Andrei's code review Co-authored-by: Andrei Litvin <[email protected]> * Restyled by clang-format * Apply Boris' suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address Boris' review suggestions --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
…#36406)" (project-chip#36475) This reverts commit 078bc30.
* Generated using ./alchemy zap --attribute="in-progress" ... ZoneManagement.adoc * Generated using ./scripts/tools/zap_regen_all.py * Remove renamed file * Restyled by whitespace * Restyled by prettier-json * Remove renamed file * Remove choice for single element --------- Co-authored-by: Restyled.io <[email protected]>
…roject-chip#36348) * Shutdown DefautICDClientStorage when destorying Android controller * Restyled by whitespace * Update DefaultICDClientStorage.h Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
* Change output folder for apps * Update integrations/docker/images/chip-cert-bins/Dockerfile * Update integrations/docker/images/chip-cert-bins/Dockerfile
…roject-chip#36477) * Restructure platform files * Move all files to src/platform * Build the wf200 in the new wifi structure * rename directory * Build the rs9116 in the new wifi structure * Build the SiWx917 NCP in the new wifi structure * Build the SiWx917 SoC in the new wifi structure * Delete wfx_host_events header in favor of the new abstraction structure * remove unnecessary includes in gn files and the cflag changes * restyle * add todo comment * remove cflag inclusion * add missing incllude * Add missing includes * Restyled by clang-format * Move wifi_args.gni file to the wifi directory * Rename Wf200WifiInterface to WifiInterface * Rename SiWxWifiInterface to WifiInterface * Rename Rsi91xWifiInterface.cpp to WifiInterface.cpp --------- Co-authored-by: Restyled.io <[email protected]>
…an MTRDevice (project-chip#36479) * [Darwin] API to list all network commissioning features supported by an MTRDevice - Expose the network commissioning feature bitset as API to know what transports are supported by the device. * Code review comments * Code review comments * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
…ject-chip#36478) SDK update for corresponding Spec change. Remove the CurrentSnapshotConfig and CurrentVideoCodecs as they are captured by the Allocated Video and Snapshot stream attributes. Also, fix a field name in the Snapshotstream allocation command. Run ZAP regen for the corresponding changes.
…ect-chip#36427) * [Fabric-Sync] Port commissioner control protocol * Add device synchronization * Fix compile error * Update examples/fabric-sync/admin/DeviceSubscription.cpp Co-authored-by: Terence Hampson <[email protected]> * Address review comments * Add debug log * Update examples/fabric-sync/admin/DeviceManager.cpp Co-authored-by: Terence Hampson <[email protected]> * Address review comments * Add endpoint check --------- Co-authored-by: Terence Hampson <[email protected]>
…roject-chip#36482) * [nxp][examples][mcxw71_k32w1] Include platform/CHIPDeviceConfig.h in FreeRtosHooks.cpp * this will include the CHIP_DEVICE_CONFIG_ENABLE_OTA_REQUESTOR macro allowing OTAIdleActivities to be called during ota. * Switch FreeRtosHooks.c to FreeRtosHooks.cpp * Add extern to functions Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by whitespace * Restyled by clang-format * Restyled by gn --------- Signed-off-by: Andrei Menzopol <[email protected]> Co-authored-by: Restyled.io <[email protected]>
…rsistence` (project-chip#36473) * Move persistence providers code into util since they depend on ember. Unit tests pass, will need to fix up apps. * Fix up more includes * Restyled by clang-format * Fix up qpg build * Also fix nrfconnect deferred attribute persistence use * Fix path * Add persistence to esp32 CMakeLists.txt * Update examples/lighting-app/qpg/BUILD.gn --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* [HVAC] Shift heating and cooling setpoints to preserve deadband, when possible * Minor function renames, fix incorrect setters * Populate deadband on setpointLimits when Auto is supported * [Thermostat] Add test for deadband handling * Restyled Python test * Fix int promotion errors on some platforms * Remove unused Python imports * Fix capitalization of structs, methods, fields, etc. * Silly C++ int promotion rules * [HVAC] Fix incorrect naming of TSTAT 2.3 test class * Fix errant quote in TC_TSTAT_2_3.py * Drop deadband fix test in favor of separate PR * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Don't use three-arg setter for attributes * Rename deadband member * Add backwards-compatibility comment for return code substitution * Restyled --------- Co-authored-by: Boris Zbarsky <[email protected]>
…#36418) * [Network.framework] Add chip_system_config_use_network_framework * [Network.framework] Update src/lib/core/CHIPConfig.h file to enable CHIP_CONFIG_IsPlatformPOSIXErrorNonCritical * [Network.framework] Update src/system/SystemConfig.h file to enable CHIP_SYSTEM_CONFIG_USE_POSIX_SOCKETS * [Network.Framework] Update src/inet/InetInterface* files with some additional #ifdef for the network framework * [Network.Framework] Update src/inet/IPAddress* files with some additional #ifdef for the network framework * [Network.framework] Update src/inet/InetInterfaceImplDefault.cpp to enable the default implementation * [Network.framework] Update src/system to not use WakeEvent/Signal when using the network framework * [Network.framework] Convert UDPEndPointImplNetworkFramework.cpp to .mm with arc support * [chip-tool] Ensure each commissioner listen onto its own udc port since Network.framework won't allow SO_REUSEPORT * [Matter.framework][darwin-framework-tool] Add chip_system_config_use_network_framework flag support * Apply suggestions from code review --------- Co-authored-by: Boris Zbarsky <[email protected]>
* [Fabric-Sync] Synchronize all required attributes * Revert commit 8126bbd * Synchronize all required attributes
…-chip#36714) * esp32: Optimize WiFi Scan Handling with Single AP Record API * esp32: add separate ScanResponseIterator for new API changes * esp32: enable ESPScanResponseIterator for compatible IDF versions * esp32: add call for clear ap scan list, used single name for iterator * esp32: move iterator release call outside, code refactoring * esp32: relocate iternum variable for iterator compatibility with older IDF versions * Make SetApData() method private
…#36810) * Check fabric-sync application with MCORE-FS tests on CI * Add test with new fabric-sync for MCORE-FS-1.5 * Use async-friendly sleep
project-chip#36800) Remove duplicate EnergyTimeUtils.h include in EVSEManufacturerImpl.cpp
…#36781) * Allow to filter python test case runs from command line * Update according to review comment
The relevant fields are nullable in both XML and spec, and the spec issue is long-resolved.
…hip#36811) Fix AndroidDeviceControllerWrapper::Shutdown() and make destructor call this shutdown, and further create mInitialized state to guarantee shutdown proceudre can be executed only once
…project-chip#36791) * [Darwin] Unstored attributes should be flushed to storage on shutdown * Added unit test * Restyled fix * Fixed unit test issue * Update src/darwin/Framework/CHIP/MTRDeviceControllerDataStore.h Co-authored-by: Boris Zbarsky <[email protected]> * Restyled by whitespace * More unit test fix * Restyled fix * Fix typo from previous suggestion. * Clarify comment for flushing write operations --------- Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
…lues. (project-chip#36819) Looks like having the base enum just inlined in the derived cluster is here to stay, at least in terms of what API consumers want in terms of ergonomics. So just go ahead and expose it.
…#36822) * Fix webapp config for code coverage tool This PR fixes the cloud deployment config so we can upload code coverage again. * Update readme with extra instructions * Restyled by prettier-markdown * Attempt to fix misspell CI error * Another attempt. Pyspelling CI checker doesn't like Yufeng's name. * Update title to "Matter SDK Coverage Report" and add SHA * Restyled by shfmt --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.