[Fabric-Sync] Port commissioner control protocol implementation #36427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36427: Size comparison from e338404 to 1b16bb1 Increases above 0.2%:
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/fs/cctrl
branch
from
1b16bb1 to
dc958b1
Compare
|
PR #36427: Size comparison from 18c0788 to dc958b1 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Nov 12, 2024
examples/fabric-sync/bridge/include/CommissionerControlDelegate.h
Outdated
Show resolved
Hide resolved
examples/fabric-sync/bridge/src/CommissionerControlDelegate.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Terence Hampson <[email protected]>
|
PR #36427: Size comparison from 18c0788 to 5da2dda Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36427: Size comparison from 18c0788 to 641726e Increases above 0.2%:
Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36427: Size comparison from 18c0788 to 73fb325 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Nov 13, 2024
Co-authored-by: Terence Hampson <[email protected]>
tehampson
reviewed
Nov 13, 2024
tehampson
approved these changes
Nov 13, 2024
joonhaengHeo
approved these changes
Nov 14, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ect-chip#36427) * [Fabric-Sync] Port commissioner control protocol * Add device synchronization * Fix compile error * Update examples/fabric-sync/admin/DeviceSubscription.cpp Co-authored-by: Terence Hampson <[email protected]> * Address review comments * Add debug log * Update examples/fabric-sync/admin/DeviceManager.cpp Co-authored-by: Terence Hampson <[email protected]> * Address review comments * Add endpoint check --------- Co-authored-by: Terence Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port commissioner control protocol implementation from fabric-admin/fabric-bridge-app to fabric-sync.
Most of the code are ported from fabric-admin/fabric-bridge-app as is, the key changes are replacing all RPC call with direct API call.
Build Fabric Sync (FS) on E1 and E2
./scripts/examples/gn_build_example.sh examples/fabric-sync out/debug/standaloneRun the Fabric Sync example app on E1 and E2
> New device with Node ID: 0000000000000002 has been successfully added.