chef: Fix FanControl mode/speed interdependence behavior #36256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements the FanControl logic to ensure the interdependent behavior between Mode/Speed/Percent is coherent. This is based on what was done in the AirPurifier examples. Changes: * Removed Custom Write/Read * Updated Zap file `SpeedMax` default to 10 instead of 100 * Forward `MatterPostAttributeChangeCallback` FanControl-related changes to `ChefFanControlManager` * Implements Mode/Speed/Percent interdependency logic based on the AirPurifier example Test: * Verified that Mode, Speed and SpeedPercent change accordingly when any of those attributes change and cross a boundary.
|
Review changes with |
|
PR #36256: Size comparison from e2ffa2d to 51788c2 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Oct 26, 2024
|
PR #36256: Size comparison from e2ffa2d to f119c9a Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36256: Size comparison from 928efd7 to 5ac4256 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36256: Size comparison from 928efd7 to e15ae5a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 30, 2024
andy31415
reviewed
Oct 30, 2024
andy31415
reviewed
Oct 30, 2024
andy31415
reviewed
Oct 30, 2024
andy31415
reviewed
Oct 30, 2024
Co-authored-by: Andrei Litvin <[email protected]>
|
PR #36256: Size comparison from 928efd7 to 0e82364 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 31, 2024
andy31415
reviewed
Oct 31, 2024
Co-authored-by: Andrei Litvin <[email protected]>
andy31415
reviewed
Nov 4, 2024
andy31415
reviewed
Nov 4, 2024
andy31415
reviewed
Nov 4, 2024
andy31415
reviewed
Nov 4, 2024
andy31415
reviewed
Nov 4, 2024
andy31415
approved these changes
Nov 4, 2024
Co-authored-by: Andrei Litvin <[email protected]>
bzbarsky-apple
approved these changes
Nov 11, 2024
|
PR #36256: Size comparison from 5d64b73 to 7dc3c05 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…p#36256) * chef: Fix FanControl mode/speed interdepency behavior This PR implements the FanControl logic to ensure the interdependent behavior between Mode/Speed/Percent is coherent. This is based on what was done in the AirPurifier examples. Changes: * Removed Custom Write/Read * Updated Zap file `SpeedMax` default to 10 instead of 100 * Forward `MatterPostAttributeChangeCallback` FanControl-related changes to `ChefFanControlManager` * Implements Mode/Speed/Percent interdependency logic based on the AirPurifier example Test: * Verified that Mode, Speed and SpeedPercent change accordingly when any of those attributes change and cross a boundary. * ifdef out code for non-fancontrol examples. * Address Boris' review feedback * Update examples/chef/common/chef-fan-control-manager.cpp Co-authored-by: Andrei Litvin <[email protected]> * Andrei's review suggestions * review suggestions: clarify Auto behavior and use struct for ranges. * Fix minor bug introduced when addressing review suggestions (!= vs ==) * Update examples/chef/common/chef-fan-control-manager.cpp Co-authored-by: Andrei Litvin <[email protected]> * fix const * Apply suggestions from Andrei's code review Co-authored-by: Andrei Litvin <[email protected]> * Restyled by clang-format * Apply Boris' suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address Boris' review suggestions --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the FanControl logic to ensure the interdependent behavior between Mode/Speed/Percent is coherent.
This is based on what was done in the AirPurifier examples.
Changes:
SpeedMaxdefault to 10 instead of 100MatterPostAttributeChangeCallbackFanControl-related changes toChefFanControlManagerTest: