-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Move Wi-Fi interface to src/platform from examples/platform #36477
Merged
mkardous-silabs
merged 19 commits into
project-chip:master
from
mkardous-silabs:refactor/move_wifi_files
Nov 13, 2024
Merged
[Silabs] Move Wi-Fi interface to src/platform from examples/platform #36477
mkardous-silabs
merged 19 commits into
project-chip:master
from
mkardous-silabs:refactor/move_wifi_files
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
force-pushed
the
refactor/move_wifi_files
branch
from
November 12, 2024 22:38
2b1ba03
to
5eea1b6
Compare
mkardous-silabs
added
submodules
Pull requests that update Submodules code
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
labels
Nov 12, 2024
PR #36477: Size comparison from b20d8ae to 5eea1b6 Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36477: Size comparison from b20d8ae to a39d7af Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36477: Size comparison from b20d8ae to 37ecf2e Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36477: Size comparison from b20d8ae to 2c21fda Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36477: Size comparison from b20d8ae to 960b0c2 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Nov 13, 2024
andy31415
approved these changes
Nov 13, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#36477) * Restructure platform files * Move all files to src/platform * Build the wf200 in the new wifi structure * rename directory * Build the rs9116 in the new wifi structure * Build the SiWx917 NCP in the new wifi structure * Build the SiWx917 SoC in the new wifi structure * Delete wfx_host_events header in favor of the new abstraction structure * remove unnecessary includes in gn files and the cflag changes * restyle * add todo comment * remove cflag inclusion * add missing incllude * Add missing includes * Restyled by clang-format * Move wifi_args.gni file to the wifi directory * Rename Wf200WifiInterface to WifiInterface * Rename SiWxWifiInterface to WifiInterface * Rename Rsi91xWifiInterface.cpp to WifiInterface.cpp --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
examples
platform
review - approved
silabs
submodules
Pull requests that update Submodules code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR moves the Silabs Wi-Fi abstraction layer from examples/platform to src/platform to fit within the new structure.
The PR has no functionnal changes. This is purely a re-structuring of our wifi support.
Note to reviewers
When moving the wifi files to the src/platform, several structural issues where found on the dependecies between components. To complete the restructuring, temporary workaround were introduces. These workarounds will be fixed in follow up PRs to go with their associated refactor.
Tests
CI