[Darwin] API to list all network commissioning features supported by an MTRDevice #36479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
Nov 13, 2024
anush-apple
commented
- Expose the network commissioning feature bitset as API to know what transports are supported by the device.
|
Review changes with |
…an MTRDevice - Expose the network commissioning feature bitset as API to know what transports are supported by the device.
anush-apple
force-pushed
the
network-features-api
branch
from
bd1204d to
44434eb
Compare
|
PR #36479: Size comparison from 59d7388 to 44434eb Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36479: Size comparison from 59d7388 to a3e2131 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Nov 13, 2024
woody-apple
approved these changes
Nov 13, 2024
|
PR #36479: Size comparison from 59d7388 to e96802b Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| - (MTRNetworkCommissioningFeature)networkCommissioningFeatures | ||
| { | ||
| std::lock_guard lock(_descriptionLock); | ||
| return [_allNetworkFeatures unsignedIntValue]; |
There was a problem hiding this comment.
So this will return a value with no bits set when the actual state might be "we don't know yet". Is that expected?
That is, should we differentiate in the API between "we don't know yet" and "we know and it supports nothing"?
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…an MTRDevice (project-chip#36479) * [Darwin] API to list all network commissioning features supported by an MTRDevice - Expose the network commissioning feature bitset as API to know what transports are supported by the device. * Code review comments * Code review comments * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.