[HVAC] Thermostat deadband handling #35673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
|
PR #35673: Size comparison from afb1a33 to b3bbfa2 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cjandhyala
reviewed
Sep 23, 2024
tcarmelveilleux
approved these changes
Sep 26, 2024
|
PR #35673: Size comparison from db11057 to 6a4a0ed Increases above 0.2%:
Full report (11 builds for cc32xx, nrfconnect, nxp, stm32, tizen)
|
|
PR #35673: Size comparison from db11057 to 3d70846 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… granbery/thermostat_deadband_fix
|
PR #35673: Size comparison from 55e2a3f to 6da9f85 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #35673: Size comparison from a854245 to e9b72fe Increases above 0.2%:
Full report (3 builds for cc32xx, stm32)
|
|
PR #35673: Size comparison from a854245 to 5d1c13b Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 9, 2024
|
PR #35673: Size comparison from 45a75ba to 8d5f05e Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* [HVAC] Shift heating and cooling setpoints to preserve deadband, when possible * Minor function renames, fix incorrect setters * Populate deadband on setpointLimits when Auto is supported * [Thermostat] Add test for deadband handling * Restyled Python test * Fix int promotion errors on some platforms * Remove unused Python imports * Fix capitalization of structs, methods, fields, etc. * Silly C++ int promotion rules * [HVAC] Fix incorrect naming of TSTAT 2.3 test class * Fix errant quote in TC_TSTAT_2_3.py * Drop deadband fix test in favor of separate PR * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Don't use three-arg setter for attributes * Rename deadband member * Add backwards-compatibility comment for return code substitution * Restyled --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs the deadband handling behavior in thermostat-server with the spec; instead of rejecting any setpoint writes which violate the deadband, it attempts to shift the complementary setpoint to preserve the deadband, only erroring if this violates the min/max for the setpoint.
Fixes #36191