Move ember-specific attribute persistence providers into src/util/persistence
#36473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests pass, will need to fix up apps.
|
Review changes with |
|
PR #36473: Size comparison from a0992d0 to 64d9acf Full report (3 builds for cc32xx, stm32)
|
|
PR #36473: Size comparison from a0992d0 to 6ffb911 Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36473: Size comparison from a0992d0 to f387b7b Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Nov 13, 2024
|
PR #36473: Size comparison from a0992d0 to 5cac419 Increases above 0.2%:
Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Nov 14, 2024
tcarmelveilleux
approved these changes
Nov 14, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…rsistence` (project-chip#36473) * Move persistence providers code into util since they depend on ember. Unit tests pass, will need to fix up apps. * Fix up more includes * Restyled by clang-format * Fix up qpg build * Also fix nrfconnect deferred attribute persistence use * Fix path * Add persistence to esp32 CMakeLists.txt * Update examples/lighting-app/qpg/BUILD.gn --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to start addressing #36472 as these persistence providers are ember-specific.
Not yet fully fixed as SafeAttributePersistenceProvider is still coupled to the ember persistence.