[release-0.5] backports for 0.5.0 rc2 #17960

tkelman · 2016-08-11T05:45:53Z

A few things aren't here yet. The curl build still needs a bit more work on master and might have to wait until rc3, and the SSH tests are disabled here with a commit that we'll hopefully be able to revert at some point, since they're causing issues on the buildbots.

The byte gets sign extended when passing to the vararg `jl_printf` and then printed as an unsigned int which might come with unwanted `0xff` prefix... (cherry picked from commit bffa84e) ref #17803

…flush-close"" This reverts commit 58a14f3.

introduced by #17522 (cherry picked from commit a3f288c) ref #17815

Fixed missing UnicodeCharacters doc/conf.py, see #17813 (cherry picked from commit f566f0d) ref #17814 remove patch copy-paste + artifacts from doc/conf.py (cherry picked from commit 6ba6d8d)

Lots of our documentation for some relatively simple iterator methods had no examples. I added a bunch, moved docstrings out of HelpDB, and tried to illustrate some common use cases. (cherry picked from commit ad5d244) ref #17790

Lots of examples for things that are probably confusing for new Julia users. Made `reducedim` and `mapreducedim` arguments more similar to the ones for `reduce` and `mapreduce`. (cherry picked from commit 3e00217)

The manual entry for doctests was way out of date! Updated with an example of what to do. (cherry picked from commit 6d3e337)

* Move math docs out of HelpDB, more examples, fix typos Found a series of typos in `cov` and friends. Added more notes about `NaN` and Julia. Made the function signatures reflect what's actually in the code. More examples for quite a few functions. * Move quadgk docs out, update formatting * Moved special functions out of HelpDB, insert some links * Updated docs for some array ops as well * Updated in response to feedback Removed calls to `rand` in doctests. Made examples better. Cleaned up function signatures. (cherry picked from commit 2d24eda)

(cherry picked from commit a1e5daf) ref #17816

It was already working for matrices (cherry picked from commit 9114ae6) ref #17816

(cherry picked from commit 06c6d59) ref #17816

(cherry picked from commit 37e9c5c) ref #17816

* Apparently `ifunc` is not supported by gcc 5 on ARM * Try even harder to workaround LLVM bug when dealing with returntwice function (cherry picked from commit f90eab3) ref #17800

(cherry picked from commit 0aac966) ref #17841

(cherry picked from commit f2863ef) ref #17836

The `edit` function on windows fails if the editor command is `atom`. It succeeds if it is instead `atom.cmd`, but then Julia fails to recognize the `atom` editor. This fixes that. (cherry picked from commit e79bee7) ref #17857

(cherry picked from commit 008b15f) ref #17855

It is now in a separate repo and not in `contrib/` (cherry picked from commit c367b42) ref #17849

Yet MORE examples from the REPL. Fixed and added links, changd some wording. (cherry picked from commit e4a377c) ref #17797

Removed calls to `rand` in the doctests. (cherry picked from commit 6df3ec0) ref #17797

(cherry picked from commit 071cd66) ref #17797

(cherry picked from commit fdef48d) ref #17797

(cherry picked from commit 6ffe1ab) ref #17797

(cherry picked from commit 16cfe4d) ref #17843

) (cherry picked from commit 6ba3b97)

(cherry picked from commit 03e9262) ref #17864

(cherry picked from commit 7f074e9)

ref #17651 (comment)

(cherry picked from commit 9c21452)

(cherry picked from commit c7fc048) ref #17871

(cherry picked from commit 8615732)

…17909) and Symmetric, it is redundant to also have an uplo argument and occasionally, it also gave the wrong result. This can therefore be considered a bugfix. (cherry picked from commit 35df9b8)

Fixes #17780 (cherry picked from commit 3f6b2b2)

* Add cross-release compatibility note to CONTRIBUTING.md * tag -> specify (cherry picked from commit dcffb4a)

ref #17911 (cherry picked from commit 091c2fd)

* improve heuristic for when to refresh line * fix trailing whitespace... * use indent when not on first line * remove unused argument and change local var to not share name with function (cherry picked from commit f84b94c)

(cherry picked from commit 8dfe9c8) ref #17947

See #16766. `ndigits(big(0),1)` doesn't raise an error, but we were sometimes (randomly, rarely) testing that it does. This change makes the test reliable. The issue of how this case should actually behave is still open. (cherry picked from commit dd09d19) ref #17952

fix output of getaddrinfo in networking and streams documentation for v0.5. (cherry picked from commit 068aa9d)

tkelman · 2016-08-11T07:03:35Z

@nanosoldier runbenchmarks(ALL, vs = "@0030eec2f332f353e6890ca289ac2aca55532dde")

(PR merge commit 92c85fd vs 0.5.0-rc0)

nanosoldier · 2016-08-11T09:39:58Z

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

tkelman · 2016-08-11T16:07:18Z

PkgEval comparison (vs rc0) finished: https://gist.github.com/c5e9489fdacaeed4a31abfe69ebbbe1b

This is a few more failures than I would like to see (9, though 8 packages went from failing to passing), would be good to get a few more eyes looking through the failure logs.

edit: BlockArrays, DistributedArrays, ForwardDiff, and PowerSeries failures are caused by this typo: 2912c9e#commitcomment-18608997

Git.jl was terminated, timeout apparently?

KristofferC · 2016-08-11T16:20:02Z

For BlockArrays it is because a typo:

julia/base/special/trig.jl

Line 324 in ad15fc9

(:acot, :atan, :acoth, :atahn, "cotangent"))

swt30 · 2016-08-11T16:26:40Z

Same for ForwardDiff, I think

ERROR: LoadError: LoadError: UndefVarError: atahn not defined
in macro expansion; at /home/vagrant/.julia/v0.5/ForwardDiff/test/DualTest.jl:388 [inlined]

tkelman · 2016-08-11T17:13:34Z

BiomolecularStructures and NullableArrays pass for me locally, so those may have been flukes. That leaves
CovarianceMatrices (cc @gragusa) and MixedModels (cc @dmbates) that look like real failures we don't know the cause of, worth bisecting.

tkelman · 2016-08-11T17:56:52Z

@andreasnoack CovarianceMatrices was broken by the backport of #17909, can you take a look?

andreasnoack · 2016-08-11T18:10:09Z

Sure. I'll do that.

tkelman · 2016-08-11T18:23:22Z

MixedModels bisected to the same commit.

andreasnoack · 2016-08-12T01:43:11Z

@tkelman Thanks for catching this before it got backported. This check is comparing a Char and a Symbol so it ends up exactly the opposite of what it should be. The tests actually captured this but unfortunately I convinced myself that the tests were wrong. #17985 reverts the old commit and adds a new commit without the bug.

(cherry picked from commit 1d5a427)

…mitian (#17909)" This reverts commit d992f3d. (cherry picked from commit 62b55ce) ref #17985

and Symmetric, it is redundant to also have an uplo argument and occasionally, it also gave the wrong result. This can therefore be considered a bugfix. (cherry picked from commit 6085103) ref #17985

* Fix atahn to atanh * More tests (cherry picked from commit 5838a12)

yuyichao and others added 30 commits August 10, 2016 21:11

Fix jl_static_show for bitstype

762a2a9

The byte gets sign extended when passing to the vararg `jl_printf` and then printed as an unsigned int which might come with unwanted `0xff` prefix... (cherry picked from commit bffa84e) ref #17803

Revert "Revert "Merge pull request #17522 from JuliaLang/jn/reliable-…

c7cc66f

…flush-close"" This reverts commit 58a14f3.

Fix #17805, spawn test failure on Windows

7306033

introduced by #17522 (cherry picked from commit a3f288c) ref #17815

Fixed doc/conf.py #17813

c573b7b

Fixed missing UnicodeCharacters doc/conf.py, see #17813 (cherry picked from commit f566f0d) ref #17814 remove patch copy-paste + artifacts from doc/conf.py (cherry picked from commit 6ba6d8d)

Moved docs out of helpDB, way more examples

3d91b01

Lots of our documentation for some relatively simple iterator methods had no examples. I added a bunch, moved docstrings out of HelpDB, and tried to illustrate some common use cases. (cherry picked from commit ad5d244) ref #17790

Move array documentation out of HelpDB, add examples (#17795)

48f7267

Lots of examples for things that are probably confusing for new Julia users. Made `reducedim` and `mapreducedim` arguments more similar to the ones for `reduce` and `mapreduce`. (cherry picked from commit 3e00217)

Added documentation for doctests (#17825)

0e7933d

The manual entry for doctests was way out of date! Updated with an example of what to do. (cherry picked from commit 6d3e337)

indices extensions for iterators & collect

730c0a3

(cherry picked from commit a1e5daf) ref #17816

Get (c)transpose for vectors working with non-1 indices

1debda4

It was already working for matrices (cherry picked from commit 9114ae6) ref #17816

Get atsign-test_approx_eq working for non-1 indices

bee5a34

(cherry picked from commit 06c6d59) ref #17816

Generalize findn and findnz for non-1 indices

3d980ca

(cherry picked from commit 37e9c5c) ref #17816

Deoptimize TLS access

631ff00

* Apparently `ifunc` is not supported by gcc 5 on ARM * Try even harder to workaround LLVM bug when dealing with returntwice function (cherry picked from commit f90eab3) ref #17800

Move docs out of helpDB, make them less verbose.

d594e10

(cherry picked from commit 0aac966) ref #17841

Add tests for date parsing (#10817)

0bbe027

(cherry picked from commit f2863ef) ref #17836

Recognize atom with a file extension.

df8dcf3

The `edit` function on windows fails if the editor command is `atom`. It succeeds if it is instead `atom.cmd`, but then Julia fails to recognize the `atom` editor. This fixes that. (cherry picked from commit e79bee7) ref #17857

AST doc - comparisons now use call unless chained

a403819

(cherry picked from commit 008b15f) ref #17855

Clarifies location of Sublime Text editing mode

630b862

It is now in a separate repo and not in `contrib/` (cherry picked from commit c367b42) ref #17849

More HelpDB pruning for Bit/SparseArray, more examples

ea617ec

Yet MORE examples from the REPL. Fixed and added links, changd some wording. (cherry picked from commit e4a377c) ref #17797

Added examples for ones, eye. Fixed up BitArray docs.

775c34e

Removed calls to `rand` in the doctests. (cherry picked from commit 6df3ec0) ref #17797

Doctests passed, gave up on ones

6903268

(cherry picked from commit 071cd66) ref #17797

Fixed line in helpdb for doctest

b9982cd

(cherry picked from commit fdef48d) ref #17797

fix docstring wording

907db9f

(cherry picked from commit 6ffe1ab) ref #17797

Move datafmt docs out, update them a bit

203c34d

(cherry picked from commit 16cfe4d) ref #17843

Update some function sigs for tasks and events, clear out HelpDB (#17846

bb40538

) (cherry picked from commit 6ba3b97)

Bump openlibm.

87f160c

(cherry picked from commit 03e9262) ref #17864

Test LibGit2 SSH authentication (#17651)

eb2f488

(cherry picked from commit 7f074e9)

Temporarily disable SSH tests until we can get them working on buildbots

8f06a6c

ref #17651 (comment)

Fix copy(region::Tuple) depwarn in FFTW (#17840)

7a5e180

(cherry picked from commit 9c21452)

More trig docstring cleanout

5b1edb5

(cherry picked from commit c7fc048) ref #17871

Keno and others added 9 commits August 10, 2016 22:28

Set an RPATH on all libraries requiring fortran in binary-dist (#17901)

1c5cdfe

(cherry picked from commit 8615732)

Remove redundant uplo argument in chol family. When using Hermitian (#…

d992f3d

…17909) and Symmetric, it is redundant to also have an uplo argument and occasionally, it also gave the wrong result. This can therefore be considered a bugfix. (cherry picked from commit 35df9b8)

Define conj and conj! for for Symmetric and Hermitian. (#17827)

b311b03

Fixes #17780 (cherry picked from commit 3f6b2b2)

Add cross-release compatibility note to CONTRIBUTING.md (#17911)

1bd4fbb

* Add cross-release compatibility note to CONTRIBUTING.md * tag -> specify (cherry picked from commit dcffb4a)

reword second tag -> find in CONTRIBUTING.md

058dcea

ref #17911 (cherry picked from commit 091c2fd)

fix missing line break in precompile error message

03cf927

(cherry picked from commit 8dfe9c8) ref #17947

fix output of getaddrinfo in networking and streams (#17931)

aa59b42

fix output of getaddrinfo in networking and streams documentation for v0.5. (cherry picked from commit 068aa9d)

tkelman added this to the 0.5.0 milestone Aug 11, 2016

Fix doctest line numbers

84ad7c7

tkelman mentioned this pull request Aug 11, 2016

Checklist of steps towards 0.5 release [candidates] #17418

Closed

16 tasks

license header for weakkeydict.jl

799af80

Keno and others added 4 commits August 12, 2016 01:26

Fix typo in libgit2 credentials callback (#17975)

a228a7a

(cherry picked from commit 1d5a427)

Revert "Remove redundant uplo argument in chol family. When using Her…

0eabf45

…mitian (#17909)" This reverts commit d992f3d. (cherry picked from commit 62b55ce) ref #17985

Remove redundant uplo argument in chol family. When using Hermitian

dccf0cc

and Symmetric, it is redundant to also have an uplo argument and occasionally, it also gave the wrong result. This can therefore be considered a bugfix. (cherry picked from commit 6085103) ref #17985

Fix atahn to atanh (#17977)

688c3d6

* Fix atahn to atanh * More tests (cherry picked from commit 5838a12)

tkelman merged commit e3d9acc into release-0.5 Aug 12, 2016

tkelman deleted the tk/backports-0.5.0-rc2 branch August 12, 2016 10:11

timholy mentioned this pull request Aug 13, 2016

Fix missing type parameter in _array_for #18009

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-0.5] backports for 0.5.0 rc2 #17960

[release-0.5] backports for 0.5.0 rc2 #17960

tkelman commented Aug 11, 2016

tkelman commented Aug 11, 2016 •

edited

Loading

nanosoldier commented Aug 11, 2016

tkelman commented Aug 11, 2016 •

edited

Loading

KristofferC commented Aug 11, 2016

swt30 commented Aug 11, 2016 •

edited

Loading

tkelman commented Aug 11, 2016

tkelman commented Aug 11, 2016

andreasnoack commented Aug 11, 2016

tkelman commented Aug 11, 2016

andreasnoack commented Aug 12, 2016

[release-0.5] backports for 0.5.0 rc2 #17960

[release-0.5] backports for 0.5.0 rc2 #17960

Conversation

tkelman commented Aug 11, 2016

tkelman commented Aug 11, 2016 • edited Loading

nanosoldier commented Aug 11, 2016

tkelman commented Aug 11, 2016 • edited Loading

KristofferC commented Aug 11, 2016

swt30 commented Aug 11, 2016 • edited Loading

tkelman commented Aug 11, 2016

tkelman commented Aug 11, 2016

andreasnoack commented Aug 11, 2016

tkelman commented Aug 11, 2016

andreasnoack commented Aug 12, 2016

tkelman commented Aug 11, 2016 •

edited

Loading

tkelman commented Aug 11, 2016 •

edited

Loading

swt30 commented Aug 11, 2016 •

edited

Loading