Fix jl_static_show for bitstype
#17803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The byte gets sign extended when passing to the vararg `jl_printf` and then printed as an unsigned int which might come with unwanted `0xff` prefix...
|
lgtm |
|
can this be tested? backport or not? |
Pretty hard for normal test. Possibly doctest.
Ideally should be on both 0.5 and 0.4.7 |
|
we should be able to write tests without too much difficulty: julia> p=Pipe()
Pipe(null => null, 0 bytes waiting)
julia> Base.link_pipe(p; julia_only_read=true, julia_only_write=true)
julia> ccall(:jl_static_show, Void, (Ptr{Void}, Any), p.in, "world")
julia> @async close(p.in)
julia> readstring(p.out)
"\"world\"" |
ranjanan
added a commit
to ranjanan/julia
that referenced
this pull request
Aug 11, 2016
The PR fixes jl_static_show for bitstypes
tkelman
pushed a commit
that referenced
this pull request
Aug 21, 2016
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
The PR fixes jl_static_show for bitstypes
tkelman
pushed a commit
that referenced
this pull request
Sep 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The byte gets sign extended when passing to the vararg
jl_printfand then printed as an unsigned int which might come with unwantedffffffprefix.This happens on my machine where
PRIx8isxwhich is the right format but doesn't truncate the input.... (If not for Windows support we could just usehhxformatting string).....