Add test for PR #17803 #17961
Add test for PR #17803 #17961
Conversation
The PR fixes jl_static_show for bitstypes
tkelman
added
test
| Base.link_pipe(p; julia_only_read=true, julia_only_write=true) | ||
| ccall(:jl_static_show, Void, (Ptr{Void}, Any), p.in, "world") | ||
| @async close(p.in) | ||
| @test readstring(p.out) == "\"world\"" |
There was a problem hiding this comment.
The only thing I was wondering about is the cache/blocking behavior of Pipe since the test is writing to a pipe without a reader.
This is also not testing what the PR fixes. You should test sth like Int128(-1) instead.
There was a problem hiding this comment.
And what's the expected output for readstring(p.out) ? "Int128(0xffffffffffffffffffffffffffffffff)"?
There was a problem hiding this comment.
The only thing I was wondering about is the cache/blocking behavior of Pipe since the test is writing to a pipe without a reader.
It should be OK; there's no blocking API call before the readstring.
There was a problem hiding this comment.
So the buffer size is larger than length("Int128(0xffffffffffffffffffffffffffffffff)") everywhere?
There was a problem hiding this comment.
the buffering is done by the writer, so it's ~2^31 minimum (on the platforms we support) :P
|
Looks like Travis timed out |
|
@yuyichao can we merge this? |
The PR #17803 fixes
jl_static_showforbitstypes. This provides a test for that PR.