improve heuristic for when to refresh line in the REPL #17868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ((position(s.input_buffer) + sizeof(s.p.prompt) + sizeof(str) - 1) < width(terminal(s))) | ||
| edit_insert(buf, str) | ||
| if !('\n' in str) && eof(buf) && | ||
| ((line_size(s) + sizeof(s.p.prompt) + sizeof(str) - 1) < width(terminal(s))) |
There was a problem hiding this comment.
sizeof(s.p.prompt) only applies to the first line. the other lines use s.indent
There was a problem hiding this comment.
In case someone somewhere has s.indent != strwidth(s.p.prompt)?
|
Any further comments here? @vtjnash for the last commit with |
tkelman
pushed a commit
that referenced
this pull request
Aug 11, 2016
* improve heuristic for when to refresh line * fix trailing whitespace... * use indent when not on first line * remove unused argument and change local var to not share name with function (cherry picked from commit f84b94c)
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
* improve heuristic for when to refresh line * fix trailing whitespace... * use indent when not on first line * remove unused argument and change local var to not share name with function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing pasting the same long function in the REPL before PR (above) and after PR (below): https://media.giphy.com/media/3o6Ztmlq9XLVMTqDgA/giphy.gif. The before PR version was going quite a while after I turned of the recording. Still not perfect, but better.
cc @vtjnash @Keno
Sort of fixes [no auto close] #15787