Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix output of getaddrinfo in networking and streams #17931

Merged
merged 1 commit into from
Aug 11, 2016
Merged

fix output of getaddrinfo in networking and streams #17931

merged 1 commit into from
Aug 11, 2016

Conversation

musm
Copy link
Contributor

@musm musm commented Aug 9, 2016

fix output of getaddrinfo in networking and streams documentation for v0.5.

fix output of getaddrinfo in networking and streams documentation for v0.5.
@kshyatt kshyatt added docs This change adds or pertains to documentation io Involving the I/O subsystem: libuv, read, write, etc. labels Aug 9, 2016
@kshyatt
Copy link
Contributor

kshyatt commented Aug 9, 2016

Hi @musm! Thanks for this - I see this is just an example, and not a doctest. Do you think you could convert it to a doctest (is this a reasonable thing to do, @tkelman?) so that if the output syntax changes in the future, it'll be easier to catch?

@tkelman
Copy link
Contributor

tkelman commented Aug 9, 2016

The output looks like it might depend on your location. I get

julia> getaddrinfo("google.com")
ip"216.58.192.14"

@musm
Copy link
Contributor Author

musm commented Aug 9, 2016

That's expected it depends on the dns server it pings. The syntax more importantly was wrong.

@kshyatt How do I convert to a doctest?

@kshyatt
Copy link
Contributor

kshyatt commented Aug 10, 2016

Hmm, if the output is going to change depending on where the docs are built it's probably not worth the effort. Nevermind! For next time, check out http://docs.julialang.org/en/latest/manual/documentation/

@tkelman tkelman merged commit 068aa9d into JuliaLang:master Aug 11, 2016
tkelman pushed a commit that referenced this pull request Aug 11, 2016
fix output of getaddrinfo in networking and streams documentation for v0.5.
(cherry picked from commit 068aa9d)
@musm musm deleted the patch-1 branch August 11, 2016 12:59
tkelman pushed a commit to tkelman/julia that referenced this pull request Aug 16, 2016
fix output of getaddrinfo in networking and streams documentation for v0.5.
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
fix output of getaddrinfo in networking and streams documentation for v0.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants