Even MORE trig doc movement... #17871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
| ($fa){T<:Number}(y::T) = ($fainv)(one(T) / y) | ||
| @doc """ | ||
| $($name)(x) | ||
| Compute the $($fn) of `x`, where the output is in radians. """ ($fa){T<:Number}(y::T) = ($fainv)(one(T) / y) |
There was a problem hiding this comment.
Did you run make docs on this? These are inverses. Is the output in radians for the hyperbolic ones?
There was a problem hiding this comment.
Just by comparing the old doc strings to the new it looks like you forgot to put the word "inverse" before the function name
There was a problem hiding this comment.
This is what happens when you write PRs on a delayed train
There was a problem hiding this comment.
Santa Barbara, the only place west of the Mississippi where Amtrak is the more convenient option?
edit: nope, guessed wrong
There was a problem hiding this comment.
I don't have a car and the San Diego airport is a pain to get to from the university. Free WiFi + comfy chair = so may doc PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and I fixed a failing doctest in the manual, so doctests pass.