Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy(region::Tuple) depwarn in FFTW #17840

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Fix copy(region::Tuple) depwarn in FFTW #17840

merged 1 commit into from
Aug 7, 2016

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 5, 2016

Fixes a deprecation warning about copying a Tuple (ref #15675).

@tkelman
Copy link
Contributor

tkelman commented Aug 6, 2016

how did you trigger that code path, and could you add a test for it?

@ViralBShah ViralBShah added the needs tests Unit tests are required for this change label Aug 6, 2016
@timholy
Copy link
Member Author

timholy commented Aug 6, 2016

Just pass a tuple for the region parameter in fft.

I added a test that would have issued the depwarn.

@tkelman tkelman removed the needs tests Unit tests are required for this change label Aug 7, 2016
@tkelman tkelman merged commit 9c21452 into master Aug 7, 2016
@tkelman tkelman deleted the teh/fft_depwarn branch August 7, 2016 07:03
ranjanan pushed a commit to ranjanan/julia that referenced this pull request Aug 8, 2016
tkelman pushed a commit that referenced this pull request Aug 11, 2016
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants