Skip to content

Commit

Permalink
Fix #17805, spawn test failure on Windows
Browse files Browse the repository at this point in the history
introduced by #17522
  • Loading branch information
tkelman committed Aug 4, 2016
1 parent 043eb26 commit a3f288c
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test/spawn.jl
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,12 @@ let out = Pipe(), echo = `$exename --startup-file=no -e 'print(STDOUT, " 1\t", r
@test_throws ArgumentError write(out, "now closed error")
@test isreadable(out)
@test !iswritable(out)
is_windows() && Base.process_events(false) # should be enough steps to fully propagate EOF now
if is_windows()
# WINNT kernel does not provide a fast mechanism for async propagation
# of EOF for a blocking stream, so just wait for it to catch up.
# This shouldn't take much more than 32ms.
Base.wait_close(out)
end
@test !isopen(out)
end
wait(ready) # wait for writer task to be ready before using `out`
Expand Down

0 comments on commit a3f288c

Please sign in to comment.