Generic Guns rework

[tenmillimaster]

Summary

SUMMARY: Mods "Completely overhauls generic guns"

Purpose of change

Generic Guns has been non-functional (to varying degrees) for a long, long time. It is difficult for content makers to maintain it, having to chase down multiple places for their work. This PR aims to close #35359 using the strategy outlined in #35427.

Describe the solution

Rather than having to copy and alter numerous items for the mod, Generic Guns will now utilize 'archetypal guns'(defined in #35483) that are defined in the mod, and are intended to stand on their own; thus, instead of carefully selecting which guns to black list, and which to not, ALL MAINLINE guns will get migrated instead to one of these archetypes.
In case a gun doesn't adequately fit to one, a new archetype will be made.

The same approach is made for gunmods, magazines, ammunition, and recipes.

Describe alternatives you've considered

Just updating the blacklist.

Testing

Not much yet. I've loaded the game just prior, to make sure there aren't any load errors related to this mod. There is a feature this work is contingent on, which produces load errors, #35545

Additional context

This has been a HUGE project, and I have likely made mistakes. Any criticism, input, or suggestions are greatly appreciated.

As I was adding guns, I expanded the # of guns slightly to what I felt was a more complete list of archetypes.

[I-am-Erk]

Whew. I'll get on reviewing this, it's gonna be a job but as one of the big proponents I guess I better.

[tenmillimaster]

Current list of known issues:
Pipe guns needed to get added to migrations.
Some mainline ammo is still craftable.
None of the Generic guns ammo is craftable?
Grenades need their reload recipes.
Pipe weapons need reload recipes.
Magnum-> Pistol ammo casing recipe.
Modified gunmod recipes.
Guns, magazines and ammo used in other recipes as tools or components need to be checked. (makeshift grenade from 00 shot for example.)
Need to check whether a gunmod can actually have an IUSE (conversion of grenade launcher gunmod to grenade pistol and back)

[I-am-Erk]

So, I think we should make a CI check that makes sure all type: ammo and type: guns items are either migrated in Generic Guns, or are present on a whitelist to say they don't need migration.

[I-am-Erk]

Here's what I've found so far

[Brian-Otten]

Just went ingame to check all the itemgroups. going to note down items that need migrating

luty smg .40
luty smg .45
luty smg 9mm
winchester m37
Browning auto 5
CZ-75
Glock 31
hi-point c9
Kel tec p32
Kel-tec p3AT
kel-tec pf-9
marlin 1895
mossberg 930 spx
PT 603
remington 1100 competition
remington 700
remington 870 express
ruger LCP
Sig p320
Walther p22
Walter p38
AT 4
m74 rocket clip
m110A1
Glock 18c
M17
m1911A1
Mk 23 MOD
mcmillan tac-50
mossberg 590A
remington 870 MCS
Magnum research BFR
Saiga-410
Taurus raging judge magnum
USAS 12
Uberti cattleman
Browning hi-power .40
Walther CCP
Walther PPQ
S&W model 10
Walther ppq 9mm
m45A1
Bond arms derringer
Ar-15
Hk417
1874 sharps
1887 bootleg shotgun
Colt lighting .45 carbine
m1987 trench gun
mac-11
Tavor TS12
IWI tavor x95
ar-10
Marlin 1895 SBL
Remington 700
Remington ACR .300
Cobray street sweeper
Franchi spas-12
PTR 603
H&K mp5k-pdw
H&K mpsd
.45-70 LFN
usas-12 drum magazine
saiga-410 drum magazine
usas-12 box magazine
saiga-410 box magazine
AF2011A1 magazine
.300ac blackout conversion kit
.410 000

ammo_shotgun_obscure spawns nothing
guns_launcher_grenade spawns nothing
guns_launcher_improvised spawns nothing
guns_smg_obscure spawns nothing
mags_shotgun_common spawns nothing

That's all the ones i could find easily, there might still be more.

EDIT:
This apparently didn't work because the test itemgroup function in the debug menu does not properly take migrations into account. So this list is sadly mostly invalid.

[esotericist]

This apparently didn't work because the test itemgroup function in the debug menu does not properly take migrations into account. So this list is sadly mostly invalid.

migrations currently only happen on save game load, because that mechanism was originally only intended to be used for obsoleted items (and thus things that would no longer be in item lists).

engineering is needed for this to work right.

See: #35545

[tenmillimaster]

I have been playtesting somewhat with a compiled copy of #35545. Most everything seems to be in order, I missed a few migrations.

Currently I'm having issues with magazines- https://media.discordapp.net/attachments/598529174302490644/666523696155852800/unknown.png?width=349&height=197

they have a copy-from from a similar mainline mag, and I was under the impression redefining a field would override it for the new item. This wasn't happening- I tried "delete" : { ammo_type: "old magammotype"} as well, but that hasn't worked.

It's now a known bug, as confirmed on discord with Ymber.

[tenmillimaster]

I've gone and cleaned up some more of the recipes, threw in a very hacky hack to make vehicle turrets and their ammo spawns happy, for 0.E (until migration works properly with vehicle ammo). There was a circular dependency error caused by 'bp_shot_scrap' and a recipe copying from it, related to the order in which they were defined, so I've gone and fixed that too.

I've added black powder versions of all the ammo, and de-referenced most of the recipes since copying and obsoleting wasn't going to work.

I've split all the pipe-weapons (pipe on a stick with a hammer) apart from the repeaters (somewhat well made firearms) in recipes, and have attempted to rationalize their difficulties and components.

[mlangsdorf]

I looked over the migrations and they seemed sensible.
I looked over the recipes for black powder weapons and they're close enough the level of detail available with CDDA's current crafting system.

[I-am-Erk]

Well let's see how that goes