Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code for applying migrations to downstream item lists. #35545

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

kevingranade
Copy link
Member

@kevingranade kevingranade commented Nov 16, 2019

Summary

SUMMARY: None

Purpose of change

Catch up migration code to match blacklisting code so that migrations can be used in content adjustment mods.

Describe the solution

Apply migrations to:

  • Item groups
  • crafting recipe components
  • Vehicle spawn contents

Additionally cancel recipes that have a migrated item as an output, presumably if the item is craftable it will already have a recipe.

@mlangsdorf mlangsdorf added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Mods Issues related to mods or modding labels Nov 16, 2019
@stale
Copy link

stale bot commented Dec 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Dec 19, 2019
@esotericist esotericist removed the stale Closed for lack of activity, but still valid. label Dec 22, 2019
@kevingranade kevingranade force-pushed the kevingranade-robust-migrations branch from 14fc18d to 51020d6 Compare January 6, 2020 06:21
@kevingranade kevingranade force-pushed the kevingranade-robust-migrations branch from 51020d6 to b032cd5 Compare January 13, 2020 03:42
@kevingranade kevingranade changed the title Add stub code for applying migrations to downstream item lists. Add code for applying migrations to downstream item lists. Jan 13, 2020
@kevingranade kevingranade marked this pull request as ready for review January 13, 2020 03:44
@ZhilkinSerg
Copy link
Contributor

ZhilkinSerg commented Jan 14, 2020

Hmm.. It breaks vehicle tests. Looks like it is unrelated as #36917 has same test issues.

@ZhilkinSerg ZhilkinSerg merged commit 2e3b2f5 into master Jan 14, 2020
@kevingranade kevingranade deleted the kevingranade-robust-migrations branch February 25, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants