Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using item migrations for generic_x mods #35427

Closed
ymber opened this issue Nov 9, 2019 · 3 comments
Closed

Using item migrations for generic_x mods #35427

ymber opened this issue Nov 9, 2019 · 3 comments
Labels
Mods Issues related to mods or modding (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter

Comments

@ymber
Copy link
Member

ymber commented Nov 9, 2019

Is your feature request related to a problem? Please describe.
Generic guns keeps getting out of date and when we give electronics and chemistry and such the same level of depth later down the line any generic_x mods people want to make for them will have the same problem.

Describe the solution you'd like
Generic item mods should define their own items and use item migration instead of blacklists. This way there would be no need to change itemgroups as whatever they spawn in core will be automatically genericized by the migrations.

Describe alternatives you've considered
A system for items inheriting a simplifies_to field from base items was discussed but it would be a lot of invasive data changes and some items would have to be special cases anyway.

Additional context
See #35359.
A new generic guns using item migrations may not be compatible with the old generic guns so we'd want to cut the old one after 0E.

@KorGgenT KorGgenT added the Mods Issues related to mods or modding label Nov 10, 2019
@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Dec 10, 2019
@esotericist
Copy link
Contributor

Still in progress.

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Dec 10, 2019
@ymber ymber added the (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter label Dec 10, 2019
@ymber
Copy link
Member Author

ymber commented Apr 2, 2020

With generic guns finished we can call this done now.

@ymber ymber closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mods Issues related to mods or modding (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter
Projects
None yet
Development

No branches or pull requests

3 participants