Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Generic Guns mod to be synchronized with current core content #35359

Closed
esotericist opened this issue Nov 6, 2019 · 2 comments · Fixed by #36839
Closed

Update Generic Guns mod to be synchronized with current core content #35359

esotericist opened this issue Nov 6, 2019 · 2 comments · Fixed by #36839
Assignees
Labels
Accessibility Issues regarding accessibility Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding (P2 - High) High priority (for ex. important bugfixes) Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Milestone

Comments

@esotericist
Copy link
Contributor

esotericist commented Nov 6, 2019

Describe the bug

The Generic Guns mod hasn't been updated in a couple of months -- and even then it might not have been complete as of that last update -- and guns have definitely been added since then and not incorporated.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Start a new world with Generic Guns enabled
  2. Observe errors (see below) due to outdated blacklists
  3. Bring up debug menu (or look at the details in 2 new weapons for caliber 50 #34236 )
  4. Search for TAC-50 (or tac50 in json)
  5. Observe gun which is not defined in generic guns either as override or blacklist

Expected behavior

Generic Guns, as an accessibility mod, should remain synchronized with the state of firearms, magazines, and ammunition in vanilla. Given that maintaining Generic Guns requires firearms knowledge, and anyone adding firearms must by definition possess that knowledge, I would argue it should be incumbent on contributors adding or updating guns to ensure Generic Guns is also updated.

Screenshots

outdated blacklist definition
image

Sum total of tac50 references in master as of this writing:
image

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 19.10; Release: 19.10; Codename: eoan;
  • Game Version: 0.D-9180-gfcbe9b840b [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Generic Guns [generic_guns]
    ]

Additional information

Anyone working on this task might want to be aware of consistency check issues (see: #20320, found by way of #31321 )

@esotericist esotericist added (P2 - High) High priority (for ex. important bugfixes) [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Magazines Ammo holding items and objects. Accessibility Issues regarding accessibility Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Nov 6, 2019
@esotericist esotericist added this to the 0.E milestone Nov 6, 2019
@tenmillimaster tenmillimaster self-assigned this Nov 7, 2019
@tenmillimaster
Copy link
Member

I don't mind doing taking a look at this.

@Night-Pryanik Night-Pryanik removed the Accessibility Issues regarding accessibility label Nov 7, 2019
@RickyVanz
Copy link
Contributor

im the contributor of Tac-50 and other's .50 sniper rifle. and i agree with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues regarding accessibility Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding (P2 - High) High priority (for ex. important bugfixes) Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants