Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 new weapons for caliber 50 #34236

Merged
merged 20 commits into from
Oct 4, 2019
Merged

2 new weapons for caliber 50 #34236

merged 20 commits into from
Oct 4, 2019

Conversation

RickyVanz
Copy link
Contributor

Summary

SUMMARY: Content "adds "Mcmillan TAC-50 and Serbu BFG-50 to 50.json"

Purpose of change

final addition to the .50 caliber weapons, so that players have more variety choice for anti-material sniper rifle.

@tenmillimaster
Copy link
Member

The stats and description on the tac 50 differ from your other PR. Why not just fix the old branch and make the PR from there?

@RickyVanz
Copy link
Contributor Author

The stats and description on the tac 50 differ from your other PR. Why not just fix the old branch and make the PR from there?

that PR was considered failure due to many wrong value and too many commit (which is unnecessary for just 2 new weapon in-game) plus the fact that i removed AS50 accidently made the PR out-of context. so i decided to start again and this time with different weapon (US-based)

@tenmillimaster
Copy link
Member

Well, go ahead and move over the stats and stuff from the old one at least.

@RickyVanz
Copy link
Contributor Author

Well, go ahead and move over the stats and stuff from the old one at least.

well, that's the problem, i forgot the old stat and description of the old PR, feel free to commit suggestion tho, im open to any suggestion and feedback.

@tenmillimaster
Copy link
Member

#34200

@RickyVanz
Copy link
Contributor Author

#34200

ohh thanks, feel free to tell me if there's anything need to change.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Sep 26, 2019
@tenmillimaster
Copy link
Member

tenmillimaster commented Sep 26, 2019

You may want to consider moving the BFG to a rarer item group or switching back to the AR-50.
Were it placed in guns_rifles_common, the BFG would need a item weight less than 1.

The AR-50 can have an item weight of 5. my bad, also very seldom seen.

@RickyVanz
Copy link
Contributor Author

You may want to consider moving the BFG to a rarer item group or switching back to the AR-50.
Were it placed in guns_rifles_common, the BFG would need a item weight less than 1.

The AR-50 can have an item weight of 5.

now this one makes me misunderstood last time, i should move that BFG to the rarer item group but which one? "rarer" or "common" one?

@tenmillimaster
Copy link
Member

It could be moved to guns_rifle_obscure.

@RickyVanz
Copy link
Contributor Author

It could be moved to guns_rifle_obscure.

good idea, gonna put it there with probability of 5.

data/json/items/gun/50.json Outdated Show resolved Hide resolved
data/json/items/gun/50.json Outdated Show resolved Hide resolved
data/json/items/magazine/50.json Outdated Show resolved Hide resolved
data/json/items/magazine/50.json Outdated Show resolved Hide resolved
RickyVanz and others added 3 commits September 30, 2019 04:03
@Night-Pryanik
Copy link
Contributor

Night-Pryanik commented Sep 30, 2019

Could you also please change material to materiel on this line?

@RickyVanz
Copy link
Contributor Author

Could you also please change material to materiel on this line?

which one? i can't find it. (for Mcmillan TAC-50 its already changed but for BFG-50 there's no word "material" on its description)

Co-Authored-By: Anton Burmistrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants