-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 new weapons for caliber 50 #34236
2 new weapons for caliber 50 #34236
Conversation
The stats and description on the tac 50 differ from your other PR. Why not just fix the old branch and make the PR from there? |
that PR was considered failure due to many wrong value and too many commit (which is unnecessary for just 2 new weapon in-game) plus the fact that i removed AS50 accidently made the PR out-of context. so i decided to start again and this time with different weapon (US-based) |
Well, go ahead and move over the stats and stuff from the old one at least. |
well, that's the problem, i forgot the old stat and description of the old PR, feel free to commit suggestion tho, im open to any suggestion and feedback. |
ohh thanks, feel free to tell me if there's anything need to change. |
You may want to consider moving the BFG to a rarer item group or switching back to the AR-50.
|
now this one makes me misunderstood last time, i should move that BFG to the rarer item group but which one? "rarer" or "common" one? |
It could be moved to guns_rifle_obscure. |
good idea, gonna put it there with probability of 5. |
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Tonkatsu <[email protected]>
Co-Authored-By: Tonkatsu <[email protected]>
Could you also please change |
which one? i can't find it. (for Mcmillan TAC-50 its already changed but for BFG-50 there's no word "material" on its description) |
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Tonkatsu <[email protected]>
Summary
SUMMARY: Content "adds "Mcmillan TAC-50 and Serbu BFG-50 to 50.json"
Purpose of change
final addition to the .50 caliber weapons, so that players have more variety choice for anti-material sniper rifle.