Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new weapon to 50.json #34200

Closed
wants to merge 30 commits into from
Closed

Add 2 new weapon to 50.json #34200

wants to merge 30 commits into from

Conversation

RickyVanz
Copy link
Contributor

@RickyVanz RickyVanz commented Sep 23, 2019

Summary

SUMMARY: Content "adds 2 new weapons to 50.json"

Purpose of change

continuing my previous PR that has been merged, i added 2 new weapon to 50.json.

Mcmillan TAC-50 and ArmaLite AR-50

RickyVanz and others added 7 commits September 23, 2019 18:24
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Sep 23, 2019
@tenmillimaster
Copy link
Member

tenmillimaster commented Sep 24, 2019

These are not weapons one would find in the United States. I strongly suggest using US-market available alternatives, or closing.

I suggest any of the following:

Serbu RN-50
Armalite AR-50
Bushmaster BA-50
Acc. Intl AX50
Noreen ULR-50
Barrett M99 or M95
Safety Harbor SHTF 50
EDM Windrunner
McMillan TAC-50
Deserttech HTI-50

@Rail-Runner
Copy link
Contributor

These are not weapons one would find in the United States.

Not even as very rare ones? I'm not fully sure, but seems like they could legally be imported (unlike full-auto guns).

@tenmillimaster
Copy link
Member

tenmillimaster commented Sep 24, 2019

These are not weapons one would find in the United States.

Not even as very rare ones? I'm not fully sure, but seems like they could legally be imported (unlike full-auto guns).

I do not believe any were manufactured for export, let alone imported into the US. US police/military have much cheaper options available.

That's a hard market to enter too- on top of customs fees and whatnot, you're entering a pretty-much already saturated market. Look at all the guns I listed above.

@RickyVanz
Copy link
Contributor Author

RickyVanz commented Sep 24, 2019

its possible to import these weapons to the US right? i mean lots of people has this gun as collection or something.

this is also being requested by many on forums on how 50.json has only 1 anti-material rifle (Barrett M107A1) and they want some variation on anti-material rifle (not just US market anti-material rifle, but from other country too)

data/json/itemgroups/guns.json Outdated Show resolved Hide resolved
data/json/itemgroups/magazines.json Outdated Show resolved Hide resolved
@tenmillimaster
Copy link
Member

These still appear to be in the wrong item group, with the wrong spawn weights.

4, in guns_rifle_common for the ar50

@RickyVanz
Copy link
Contributor Author

These still appear to be in the wrong item group, with the wrong spawn weights.

4, in guns_rifle_common for the ar50

done.

@ThomasLinkin
Copy link

Your gun should be put in those Military Bunker or in those really big Mansion. Shouldn't rip off these guns off the game,since they are powerful ,yes, but you can try to limited the spawn rate. I mean,check the Barrett 50 Cal as an example. I can find it with a really high chance in those gun store with a gun safe and bunch of wooden boxes in the back of the store,which is ridiculous since i don't think that gun is that much common

@RickyVanz
Copy link
Contributor Author

Your gun should be put in those Military Bunker or in those really big Mansion. Shouldn't rip off these guns off the game,since they are powerful ,yes, but you can try to limited the spawn rate. I mean,check the Barrett 50 Cal as an example. I can find it with a really high chance in those gun store with a gun safe and bunch of wooden boxes in the back of the store,which is ridiculous since i don't think that gun is that much common

yeah, i have changed the prob to be much smaller now

@tenmillimaster
Copy link
Member

tenmillimaster commented Sep 25, 2019

@ThomasLinkin none of these firearms belong in military hands, save for the tac 50. Any additional tac 50's would supplant m107's, over the amount already here.

@@ -204,6 +205,8 @@
{ "item": "l_mbr_223", "prob": 10, "charges-min": 0, "charges-max": 32 },
{ "item": "l_long_45", "prob": 30, "charges-min": 0, "charges-max": 12 },
{ "item": "m14ebr", "prob": 15, "charges-min": 0, "charges-max": 20 },
{ "item": "ar50", "prob": 15, "charges-min": 0, "charges-max": 1 },
{ "item": "as50", "prob": 20, "charges-min": 0, "charges-max": 10 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide sources for the AS 50 being imported for the commercial market and available for sale through FFL's?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have it, but lots of people i ask around internet says that there is AS 50 in US.

Copy link
Member

@tenmillimaster tenmillimaster Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RickyVanz if there are, you should be able to find one for sale somewhere. Or heck, send AI an email asking if any are available/have been imported.

If it's something that has to be special ordered, it's not going to even really be common enough to put in unless you crank everything else's weights way up. Special order for Beverly hills SWAT is so so, but otherwise no.

Lots of people on the internet isn't a very good source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lots of people around the internet" isn't a source. If it's not used by us armed forces or police and it's not readily available to private citizens, it doesn't belong in the game.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allright, should i delete the AS 50?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, leaving it in only in the swat item group is sufficient.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowhere, it spawns appropriately already. Just delete the AS50 additions you've made and leave the one in SWAT alone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allright, that means i replace my previously merged PR with this new one..

at least now there is variety for .50 cal, that's what users on discourse forum want 😄

@@ -265,6 +268,7 @@
{ "item": "ak74", "prob": 60, "charges-min": 0, "charges-max": 30 },
{ "item": "an94", "prob": 40, "charges-min": 0, "charges-max": 30 },
{ "item": "bh_m89", "prob": 20, "charges-min": 0, "charges-max": 7 },
{ "item": "as50", "prob": 20, "charges-min": 0, "charges-max": 10 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still civilian ownership.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where should i move it?

@@ -21,6 +21,8 @@
[ "hk46mag", 15 ],
[ "hk46bigmag", 5 ],
[ "m107a1mag", 50 ],
[ "as50mag", 10 ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh dang it 😄

thanks for remind me.

@tenmillimaster
Copy link
Member

Why are you removing the AS50?

I think you're misunderstanding me.

It can stay as a rare spawn for swat, and that's it. This is out of scope from your PR, just focus on the two guns you have and don't mess with other stuff.

@RickyVanz
Copy link
Contributor Author

RickyVanz commented Sep 26, 2019

Why are you removing the AS50?

I think you're misunderstanding me.

It can stay as a rare spawn for swat, and that's it. This is out of scope from your PR, just focus on the two guns you have and don't mess with other stuff.

oh my god.. i misunderstood..

allright.. i'll try to open new PR, this one is too much.

@RickyVanz RickyVanz closed this Sep 26, 2019
@RickyVanz RickyVanz reopened this Sep 26, 2019
@RickyVanz RickyVanz closed this Sep 26, 2019
@ThomasLinkin
Copy link

Nah, why don't you set it into those Merchants? It's the apocalypse they sure as hell could put their hands on it. But it has to be expensive. Around a few hundred thousand bucks.or Swat as well. Put it as the starting items for Bionic Sniper instead of the current gun (i forgot the name but the ammo of that gun are hard to find)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants