Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate vehicle turret ammo spawns #47456

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

anothersimulacrum
Copy link
Member

Summary

Bugfixes "Migrate vehicle turret ammo spawns"

Purpose of change

Fixes #46577
These weren't migrated, and some hacks existed to ease this in generic guns.

Describe the solution

Remove those hacks, and migrate ammo spawns in vehicle turrets.

Describe alternatives you've considered

See #36839 (comment) for more details on why these hacks existed.

Testing

Spawn in a humvee with generic guns, see that it spawns the proper ammo.

These weren't migrated, and some hacks existed to ease this in generic
guns.
Remove those hacks, and migrate ammo spawns in vehicle turrets.

See
CleverRaven#36839 (comment)
for more details on why these hacks existed.
@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mods: Generic Guns Anything to do with Generic Guns labels Feb 13, 2021
@ZhilkinSerg ZhilkinSerg merged commit 0b51371 into CleverRaven:master Feb 13, 2021
@anothersimulacrum anothersimulacrum deleted the nore branch February 13, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mods: Generic Guns Anything to do with Generic Guns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Generic Guns] Ammo stacking bug
2 participants