Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Generic Guns] Ammo stacking bug #46577

Closed
KyleFRS opened this issue Jan 5, 2021 · 1 comment · Fixed by #47456
Closed

[Generic Guns] Ammo stacking bug #46577

KyleFRS opened this issue Jan 5, 2021 · 1 comment · Fixed by #47456
Labels
<Bug> This needs to be fixed Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns (S2 - Confirmed) Bug that's been confirmed to exist
Milestone

Comments

@KyleFRS
Copy link

KyleFRS commented Jan 5, 2021

Describe the bug

I have 2 stacks of rifle ammo, ball and they do not seem to stack together when I try to put them into a rifle mag.

Steps To Reproduce

I came across the ammo.

Expected behavior

They should be able to be loaded into a mag together.

Screenshots

image

Versions and configuration

0.E-2
Windows 10

Here is my save.
Namahakara.zip

@esotericist esotericist added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns (S2 - Confirmed) Bug that's been confirmed to exist <Bug> This needs to be fixed and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jan 5, 2021
@esotericist
Copy link
Contributor

esotericist commented Jan 5, 2021

so on investigation, it turns out the stack of 3 "rifle ammo, ball" is actually a stack of 762_51. the item hadn't properly migrated yet, and when the player reloaded the save, it correctly migrates to rifle ammo, AP

there are three problems here:
a) it looks like items are still not fully migrating mid-session, which is unfortunate and i previously thought had been resolved
b) the contents of the temp-ammo_redefine_hack.json are either incorrect (762_51 should be copy-from the AP ammo instead of the ball ammo) or should no longer be in use (inclear, depends on resolution of a above)
c) the debug mode item info is not showing the item id, which would have immediately made it clear why the two ammo items were not stacking

@anothersimulacrum anothersimulacrum added this to the 0.F milestone Jan 5, 2021
@esotericist esotericist changed the title Ammo stacking bug [Generic Guns] Ammo stacking bug Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants