Disable tests for generic_guns mod #37206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
Mods
|
We should have a way for two mods to declare that they are incompatible, so that the CI can automatically figure out that it needs to perform multiple independent tests. |
This was referenced Jan 26, 2020
jbytheway
added a commit
to jbytheway/Cataclysm-DDA
that referenced
this pull request
Aug 19, 2020
This was previously blacklisted in CleverRaven#37206 due to a conflict with ew_pack (Icecoon's Arsenal) but that's no longer a core mod, so we can re-enable generic guns for testing. Fix the few minor JSON errors that tests caught in this mod.
kevingranade
pushed a commit
that referenced
this pull request
Aug 20, 2020
This was previously blacklisted in #37206 due to a conflict with ew_pack (Icecoon's Arsenal) but that's no longer a core mod, so we can re-enable generic guns for testing. Fix the few minor JSON errors that tests caught in this mod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
generic_gunsandew_packmods are not working well together (see #21728) which causes [errors in CI](It looks like it breaks tests as they run both withgeneric_gunsandew_packenabled.These two mods weren't working well together (see #21728), so we should probably just change how mod tests are run and do not put all the mods into one basket.) after #37080 is merged.
Describe the solution
Added
generic_gunsmod to blacklist for mod checking (this should be reverted once this mod is reworked and would be compatible with other gun mods, see #36839).Testing
Make sure there are no issues with either of mentioned mods in CI.