Unblacklist generic guns mod from tests #43044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously blacklisted in CleverRaven#37206 due to a conflict with ew_pack (Icecoon's Arsenal) but that's no longer a core mod, so we can re-enable generic guns for testing. Fix the few minor JSON errors that tests caught in this mod.
anothersimulacrum
added
Code: Tests
Merged
|
There is possible issue with some items in generic guns mod: |
|
Yeah, I've seen that error. Thanks for helping to clarify it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
This was previously blacklisted in #37206 due to a conflict with ew_pack (Icecoon's Arsenal) but that's no longer a core mod, so we can re-enable generic guns for testing.
Describe the solution
Fix the few minor JSON errors that tests caught in this mod.
Remove generic guns from the blacklist.
Describe alternatives you've considered
None.
Testing
Running unit tests (with no tests) to check data loading errors.
Additional context
Would be good to get a few more things unblacklisted before 0.F so we have better test coverage.