Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L3out ansible module is incomplete #126

Closed
ttrabatt opened this issue Feb 4, 2021 · 5 comments
Closed

L3out ansible module is incomplete #126

ttrabatt opened this issue Feb 4, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ttrabatt
Copy link

ttrabatt commented Feb 4, 2021

L3out ansible module does not support the complete configuration of all Logical Node and Interface Profiles, BGP config (including wan and local ASN), BFD settings, and BGP options

Module should support single/dual or multiple leaves and single/dual or multiple WAN router to peer with.
Module should support the complete config Traditional L3out as well as new SR/MPLS L3out

Available for further discussion
Tiziano

@lhercot lhercot added the enhancement New feature or request label Jan 28, 2022
@mupett
Copy link

mupett commented Feb 11, 2022

L3out ansible module does not support the complete configuration of all Logical Node and Interface Profiles, BGP config (including wan and local ASN), BFD settings, and BGP options

Module should support single/dual or multiple leaves and single/dual or multiple WAN router to peer with. Module should support the complete config Traditional L3out as well as new SR/MPLS L3out

Available for further discussion Tiziano

More urgent I think, it is missing for L3out SVI the ability to configure IPs, encap and other VPC stuff.
Thanks and regards.

@akinross
Copy link
Collaborator

Note to include also missing functionality as described in: #432

@lhercot
Copy link
Member

lhercot commented Dec 20, 2023

The SR-MPLS completeness is tracked as part of issue #125

@gmicol
Copy link
Collaborator

gmicol commented Dec 21, 2023

New/extended Modules to provide further L3Out configurations

Add loopback address to L3Out logical node

Pull Request #476

  • aci_l3out_logical_node (class: l3extRsNodeL3OutAtt) - extended module
  • Additional 1:1 child classes:
  • loopback_address (class: 3extLoopBackIfP) - new attribute

Add floating SVI configuration

Pull Request #478

  • aci_l3out_floating_svi (l3extVirtualLIfP) - new module
  • Additional child classes:
  • aci_l3out_floating_svi_path (class: l3ext:RsDynPathAtt) - new module
  • aci_l3out_floating_svi_path_secondary_ip (class: l3extIp) - new module
  • aci_l3out_floating_svi_secondary_ip (class: l3extIp) - new module

Add Route Map Control configuration

Pull Requests #479 and #495

  • aci_route_control_profile (class: rtcrtlProfile) - new module
  • Additional child classes:
  • aci_route_control_context (class: rtcrtlCtxP) - new module
  • aci_match_rule (class: rtcrtlSubjP) - new module
  • Additional child classes:
  • aci_match_as_path_regex_term (class: rtctrlMatchAsPathRegexTerm) - new module
  • aci_match_community_factor (class: rtctrlMatchCommFactor) - new module
  • aci_match_community_regex_term (class: rtctrlMatchCommRegexTerm) - new module
  • aci_match_community_term (class: rtctrlMatchCommTerm) - new module
  • aci_match_route_destination (class: rtctrlMatchRtDest) - new module
  • aci_tenant_action_rule_profile (class: rtctrlAttrP) - extended module
  • Additional 1:1 child classes:
  • set_community (class: rtctrlSetComm) - new attribute
  • set_dampening (class: rtctrlSetDamp) - new attribute
  • set_next_hop (class: rtctrlSetNh) - new attribute
  • set_preference (class: rtctrlSetPref) - new attribute
  • set_metric (class: rtctrlSetRtMetric) - new attribute
  • set_metric_type (class: rtctrlSetRtMetricType) - new attribute
  • set_route_tag (class: rtctrlSetTag) - new attribute
  • set_weight (class: rtctrlSetWeight) - new attribute
  • Additional child classes:
  • aci_action_rule_additional_communities (class: rtctrlSetAddComm) - new module
  • aci_action_rule_set_as_path (class: rtctrlSetASPath) - new module
  • aci_action_rule_set_as_path_asn (class: rtctrlSetASPathASN) - new module

Add BGP configurations for L3Out and new BGP options

Pull Requests #491 and #519

  • aci_l3out_bgp_protocol_profile (class: bgpProtP) - new module
  • aci_bgp_best_path_policy (class: bgpBestPathCtrlPol) - new module
  • aci_bgp_timers_policy (class: bgpCtxPol) - new module
  • aci_bgp_address_family_context_policy (class: bgpCtxAfPol) - new module
  • aci_bgp_peer_prefix_policy (class: bgpPeerPfxPol) - new module
  • aci_bgp_route_summarization_policy (class: bgpRtSummPol) - new module

Add HSRP configuration for L3Out

Pull Request #505

  • aci_l3out_hsrp_interface_profile (class: hsrpIfP) - new module
  • aci_interface_policy_hsrp (class: hsrpIfPol) - new module
  • Additional child classes:
  • aci_l3out_hsrp_group (class: hsrpGroupP) - new module
  • aci_l3out_hsrp_secondary_vip (class: hsrpSecVip) - new module

Add BFD and BFD Multihop configurations for L3Out

Pull Request #492

  • aci_l3out_bfd_interface_profile (class: bfdIfP) - new module
  • aci_interface_policy_bfd (class: bfdIfPol) - new module
  • aci_l3out_bfd_multihop_interface_profile (class: bfdMhIfP) - new module
  • aci_interface_policy_bfd_multihop (class: bfdMhIfPol) - new module
  • aci_bfd_multihop_node_policy (class: bfdMhNodePol) - new module

Add PIM configuration for L3Out

Pull Request #537

  • aci_interface_policy_pim (class: pimIfPol) - new module
  • aci_pim_route_map_policy (class: pimRouteMapPol) - new module
  • Additional child classes:
  • aci_pim_route_map_entry (class: pimRouteMapEntry) - new module

Add EIGRP configuration for L3Out

Pull Request #528

  • aci_l3out_eigrp_interface_profile (class: eigrpIfP) - new module
  • aci_interface_policy_eigrp (class: eigrpIfPol) - new module
  • aci_keychain_policy (class: fvKeyChainPol) - new module
  • Additional child classes:
  • aci_key_policy (class: fvKeyPol) - new module

Add DHCP relay label for L3Out

Pull Request #551

  • aci_l3out_dhcp_relay_label (class: dhcpLbl) - new module
  • aci_dhcp_option_policy (class: dhcpOptionPol) - new module
  • Additional child classes:
  • aci_dhcp_option (class: dhcpOption) - new module

Add QoS custom policy

Pull Request #561

  • aci_qos_custom_policy (class: qosCustomPol) - new module
  • Additional child classes:
  • aci_qos_dscp_class (class: qosDscpClass) - new module
  • aci_qos_dot1p_class (class: qosDot1PClass) - new module

Add Netflow Monitor Policy

  • aci_netflow_monitor_policy (class: netflowMonitorPol) - new module
  • Additional child classes:
  • aci_netflow_exporter_policy (class: netflowExporterPol) - new module
  • aci_netflow_record_policy (class: netflowRecordPol) - new module

Add missing L3Out Logical Interface Profile configurations

  • aci_l3out_logical_interface_profile (class: l3extLIfP) - extended module
  • Additional 1:1 child classes:
  • igmp (class: igmpIfP) - new attribute
  • pim_IPv4 (class: pimIfP) - new attribute
  • pim_IPv6 (class: pimIPV6IfP) - new attribute
  • qos_custom_policy (class: l3extRsLIfPCustQosPol) - new attribute
  • netflow_monitor_policy (class: l3extRsLIfPToNetflowMonitorPol) new attribute

@lhercot
Copy link
Member

lhercot commented Feb 28, 2024

Closing this issue as all the associated PRs have been merged.

@lhercot lhercot closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants